feat(splits): leverage winlayout #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortcuts
added a commit
that referenced
this pull request
Aug 29, 2024
🤖 I have created a release *beep* *boop* --- ## [1.15.0](v1.14.1...v1.15.0) (2024-08-29) ### Features * **splits:** leverage winlayout ([#375](#375)) ([ba74759](ba74759)) ### Bug Fixes * inconsistent resizes on vsplits ([#380](#380)) ([af5c9bc](af5c9bc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Clément Vannicatte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📃 Summary
the custom logic for vsplit handling has reached its limits, it's now impossible to handle every edge cases and might make the user experience clunky.
This winlayout refactoring aims at increasing consistency by considering nvim as the source of truth, as it should be. Leveraging also allows the plugin to avoid debouncing and concurrent refreshes in order to wait for the ui to be refreshed, we can now just evaluate the API instantly.
This also unlocks nnp buffers to be CONSISTENTLY on both sides, where they should always be.
supersede #374
closes #368