feat: add mini.starter dashboard to constants #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortcuts
reviewed
Aug 16, 2024
lua/no-neck-pain/util/constants.lua
Outdated
| @@ -82,6 +82,6 @@ Co.INTEGRATIONS = { | |||
| ---Dashboards filetypes that delays the plugin enable step until next buffer entered. | |||
| --- | |||
| ---@private | |||
| Co.DASHBOARDS = { "dashboard", "alpha" } | |||
| Co.DASHBOARDS = { "dashboard", "alpha", "ministarter" } | |||
There was a problem hiding this comment.
since this requires the filetype, it should be:
Suggested change
| Co.DASHBOARDS = { "dashboard", "alpha", "ministarter" } | |
| Co.DASHBOARDS = { "dashboard", "alpha", "started" } |
I wonder why it worked for you 🤔
There was a problem hiding this comment.
This is weird... when I try started instead of ministarter it breaks for me.
What I did was start nvim without files so I'm in the dashboard and ran :set ft? to see what ft was set, this returned ministarter so that's why I set it to that.
Here are the relevant portions of my config:
require("lazy").setup({
{
"echasnovski/mini.nvim",
config = function()
local starter = require("mini.starter")
local nvim_header = [[ ... ]]
starter.setup({
header = nvim_header,
})
},
-- (...)
{
"florzanetta/no-neck-pain.nvim",
lazy = false,
priority = 1000,
version = "*",
opts = {
-- debug = true,
width = 160,
autocmds = {
enableOnVimEnter = true,
},
},
},
}There was a problem hiding this comment.
ah I just realized I did a typo, it should be starter not started, and since we do a partial match on the ft, it would cover both ministarter and starter
shortcuts
changed the title
shortcuts
approved these changes
Aug 29, 2024
shortcuts
pushed a commit
that referenced
this pull request
Aug 29, 2024
🤖 I have created a release *beep* *boop* --- ## [1.16.0](v1.15.0...v1.16.0) (2024-08-29) ### Features * add mini.starter dashboard to constants ([#377](#377)) ([d8168ac](d8168ac)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📃 Summary
I use mini.starter as a dashboard and I enjoy your plugin very much. This fixes the integration between them.
Thanks for reviewing!
📸 Preview
Before change:
After change:
