-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENG-3615: getOrdinalsFtBalance Improvements #353
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordankzf
changed the title
Jordankzf/sip 10 brc 10 improvements
getOrdinalsFtBalance Improvements
Jan 19, 2024
jordankzf
force-pushed
the
jordankzf/sip-10-brc-10-improvements
branch
from
January 19, 2024 03:58
7b3e980
to
266644a
Compare
jordankzf
changed the title
getOrdinalsFtBalance Improvements
ENG-3615: getOrdinalsFtBalance Improvements
Jan 19, 2024
15 tasks
abdulhaseeb4239
approved these changes
Jan 22, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔘 PR Type
What kind of change does this PR introduce?
Removes forcedvisible: true
from getOrdinalsFtBalance (possibly breaking)📜 Background
Provide a brief explanation of why this pull request is needed. Include the problem you are solving or the functionality you are adding. Reference any related issues.
Issue Link: #[issue_number]
Context Link (if applicable):
🔄 Changes
Does this PR introduce a breaking change?
Changes:
Impact:
If a downstream app that uses getOrdinalsFtBalance previously assumes that visible is set to true, it will now have to manually initialize it as true.🖼 Screenshot / 📹 Video
✅ Review checklist
Please ensure the following are true before merging: