Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-3615: getOrdinalsFtBalance Improvements #353

Merged
merged 8 commits into from
Jan 22, 2024

Conversation

jordankzf
Copy link
Contributor

@jordankzf jordankzf commented Jan 19, 2024

🔘 PR Type

What kind of change does this PR introduce?

  • Extends FungibleToken and Coin from BaseToken (non-breaking)
  • Removes forced visible: true from getOrdinalsFtBalance (possibly breaking)
  • Returns ordinal ticker as principal (non-breaking)
  • Enforce upper case ordinal ticker (non-breaking)
  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

📜 Background

Provide a brief explanation of why this pull request is needed. Include the problem you are solving or the functionality you are adding. Reference any related issues.

Issue Link: #[issue_number]
Context Link (if applicable):

🔄 Changes

Does this PR introduce a breaking change?

  • Yes, Incompatible API changes
  • No, Adds functionality (backwards compatible)
  • No, Bug fixes (backwards compatible)

Changes:

  • What has been modified, added, or removed
  • Which are breaking changes

Impact:

If a downstream app that uses getOrdinalsFtBalance previously assumes that visible is set to true, it will now have to manually initialize it as true.

  • How it improves performance, fixes bugs, adds functionality, etc.
  • Impact on downstream apps, link to issues or PRs for migration
  • What to test

🖼 Screenshot / 📹 Video

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@jordankzf jordankzf changed the title Jordankzf/sip 10 brc 10 improvements getOrdinalsFtBalance Improvements Jan 19, 2024
@jordankzf jordankzf force-pushed the jordankzf/sip-10-brc-10-improvements branch from 7b3e980 to 266644a Compare January 19, 2024 03:58
@jordankzf jordankzf self-assigned this Jan 19, 2024
api/ordinals.ts Outdated Show resolved Hide resolved
api/ordinals.ts Outdated Show resolved Hide resolved
@jordankzf jordankzf changed the title getOrdinalsFtBalance Improvements ENG-3615: getOrdinalsFtBalance Improvements Jan 19, 2024
Copy link
Contributor

Test this PR with npm i --save-exact @secretkeylabs/[email protected]

@jordankzf jordankzf merged commit 73a6152 into develop Jan 22, 2024
3 checks passed
@jordankzf jordankzf deleted the jordankzf/sip-10-brc-10-improvements branch January 22, 2024 12:51
@teebszet teebszet mentioned this pull request Jan 23, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants