[ENG-3614] feat: Ability to manage a BRC-20 token's visibility (hide) #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Design pattern review:
Completed: secretkeylabs/xverse-core#353 |
jordankzf
changed the title
This reverts commit 97dde6e.
…abs/xverse-web-extension into jordankzf/hide-brc-20
jordankzf
requested review from
abdulhaseeb4239
and removed request for
teebszet
teebszet
changed the title
teebszet
reviewed
Jan 24, 2024
teebszet
reviewed
Jan 24, 2024
…abs/xverse-web-extension into jordankzf/hide-brc-20
|
Test with build here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/7638453500 |
teebszet
approved these changes
Jan 24, 2024
DuskaT021
added
testing
jordankzf
added a commit
that referenced
this pull request
Jan 28, 2024
…#765) * Add UpdateVisibleBrc20CoinListKey * Bicoin toggled first attempt * Fix ScrollableContainer not taking full height * Don't override existing token's visiblity setting * Hide brc20Coins if visible === false * Delegate logic upstream to xverse-core * Copy pasta * Rename getFtTicker to more generic name * CSS showDivider alternative * Revert "CSS showDivider alternative" This reverts commit 97dde6e. * Bump to beta version of xverse-core * xverse-core will default visible to true * Bump xverse-core again * Bump xverse-core again * BRC-20 fiat value support * Fix triple source of truth bug 🤪 * Update Brc20Token type for getBrc20Tokens * Remove fallback * Concurrent fetching * Stop naively assuming brc20 tokens have no principal * Bump xverse-core * fix: brc20 detail page should have round token image * chore: bump core beta version * refactor: css only for manage token dividers * refactor: remove a lot of fluff and use FiatAmountText component * Safe type assertion * FREE THYSELF FROM TYPECASTS * Tim's changes * Bump xverse-core to v9.1.0 * tokenFiatRate can be passed directly * Fix closing extension does not apply changes bug --------- Co-authored-by: Tim Man <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔘 PR Type
Dependent on: secretkeylabs/xverse-core#353
What kind of change does this PR introduce?
Lets users hide BRC-20 tokens if they wish, on the Manage Tokens screen.
📜 Background
Provide a brief explanation of why this pull request is needed. Include the problem you are solving or the functionality you are adding. Reference any related issues.
Issue Link: #[issue_number]
Context Link (if applicable):
🔄 Changes
Enumerate the changes made in this pull request, detailing what has been modified, added, or removed. Include technical details and implications if necessary.
Impact:
🖼 Screenshot / 📹 Video
Include screenshots or a video demonstrating the changes. This is especially helpful for UI changes.
✅ Review checklist
Please ensure the following are true before merging: