Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get brc-20 tokens API #356

Merged
merged 5 commits into from
Jan 24, 2024
Merged

feat: get brc-20 tokens API #356

merged 5 commits into from
Jan 24, 2024

Conversation

abdulhaseeb4239
Copy link
Contributor

🔘 PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

📜 Background

Add a function to get the BRC-20 tokens data from Xverse API

Issue Link: https://linear.app/xverseapp/issue/ENG-3500/[tkn-1-mob📱]-☑️-control-brc-20-display-via-manage-tokens-screen

🔄 Changes

Does this PR introduce a breaking change?

  • Yes, Incompatible API changes
  • No, Adds functionality (backwards compatible)
  • No, Bug fixes (backwards compatible)

Changes:

  • Added a new function in api/xverse.ts to get the BRC-20 tokens data from Xverse API

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@DuskaT021
Copy link
Contributor

branch is outdated @abdulhaseeb4239 fv

api/xverse.ts Outdated Show resolved Hide resolved
types/api/xverse/coins.ts Outdated Show resolved Hide resolved
Copy link
Contributor

Test this PR with npm i --save-exact @secretkeylabs/[email protected]

@teebszet teebszet merged commit 9950bde into develop Jan 24, 2024
3 checks passed
@teebszet teebszet deleted the abdulhaseeb/eng-3508 branch January 24, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants