Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change search latency metric from us unit to ms unit #37806

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Nov 19, 2024

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 19, 2024
Copy link
Contributor

mergify bot commented Nov 19, 2024

@zhagnlu Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. kind/bug Issues or changes related a bug labels Nov 19, 2024
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Nov 19, 2024
Copy link
Contributor

mergify bot commented Nov 19, 2024

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 19, 2024

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 19, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

@foxspy foxspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@czs007
Copy link
Collaborator

czs007 commented Nov 19, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, foxspy, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Nov 19, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.04%. Comparing base (7c5a801) to head (2d51f71).
Report is 11 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37806      +/-   ##
==========================================
+ Coverage   81.02%   81.04%   +0.01%     
==========================================
  Files        1358     1358              
  Lines      190427   190427              
==========================================
+ Hits       154288   154325      +37     
+ Misses      30650    30624      -26     
+ Partials     5489     5478      -11     
Components Coverage Δ
Client 72.16% <ø> (ø)
Core 68.87% <100.00%> (ø)
Go 83.21% <ø> (+0.02%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/exec/operator/FilterBitsNode.cpp 92.98% <100.00%> (ø)
internal/core/src/exec/operator/GroupByNode.cpp 97.56% <100.00%> (ø)
...ternal/core/src/exec/operator/VectorSearchNode.cpp 98.07% <100.00%> (ø)

... and 27 files with indirect coverage changes

---- 🚨 Try these New Features:

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Nov 20, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 20, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 21, 2024

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 21, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Collaborator

czs007 commented Nov 24, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 62af24c into milvus-io:master Nov 24, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants