-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change search latency metric from us unit to ms unit #37806
Conversation
@zhagnlu Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
c308c6c
to
9968374
Compare
@zhagnlu cpp-unit-test check failed, comment |
@zhagnlu go-sdk check failed, comment |
@zhagnlu E2e jenkins job failed, comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
9968374
to
18d01de
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, foxspy, zhagnlu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@zhagnlu E2e jenkins job failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #37806 +/- ##
==========================================
+ Coverage 81.02% 81.04% +0.01%
==========================================
Files 1358 1358
Lines 190427 190427
==========================================
+ Hits 154288 154325 +37
+ Misses 30650 30624 -26
+ Partials 5489 5478 -11
|
/run-cpu-e2e |
@zhagnlu E2e jenkins job failed, comment |
18d01de
to
9af4c35
Compare
@zhagnlu go-sdk check failed, comment |
@zhagnlu E2e jenkins job failed, comment |
Signed-off-by: luzhang <[email protected]>
9af4c35
to
2d51f71
Compare
/lgtm |
#37805