Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change search latency metric from us unit to ms unit #37808

Closed
wants to merge 1 commit into from

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Nov 19, 2024

pr: #37806

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 19, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 19, 2024
Copy link
Contributor

@foxspy foxspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: foxspy, zhagnlu
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhagnlu zhagnlu closed this Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.22%. Comparing base (8ba0a4a) to head (33d96f5).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #37808      +/-   ##
==========================================
+ Coverage   80.95%   83.22%   +2.27%     
==========================================
  Files        1305     1015     -290     
  Lines      182900   157474   -25426     
==========================================
- Hits       148069   131061   -17008     
+ Misses      29627    21210    -8417     
+ Partials     5204     5203       -1     
Components Coverage Δ
Client ∅ <ø> (∅)
Core ∅ <ø> (∅)
Go 83.25% <ø> (+<0.01%) ⬆️

see 310 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants