fix: change search latency metric from us unit to ms unit #37807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zhagnlu Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”) |
mergify
bot
added
do-not-merge/missing-related-pr
kind/bug
Signed-off-by: luzhang <[email protected]>
zhagnlu
force-pushed
the
change_lantency_metric_2.4
branch
from
d5a7bfa
to
9e026d6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #37807 +/- ##
==========================================
+ Coverage 80.63% 83.68% +3.04%
==========================================
Files 1069 801 -268
Lines 166978 140514 -26464
==========================================
- Hits 134643 117587 -17056
+ Misses 27930 18508 -9422
- Partials 4405 4419 +14 |
|
/approve |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, foxspy, zhagnlu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr: #37806