Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits for JOSS reviews #195

Closed
wants to merge 136 commits into from
Closed

Edits for JOSS reviews #195

wants to merge 136 commits into from

Conversation

mdtanker
Copy link
Owner

No description provided.

Copy link

🔔 Thank you for raising your pull request.
Version 0.3.3 is already released. No increase in version will be made when this PR is merged.

Copy link

🔔 Thank you for raising your pull request.
Version 0.3.3 is already released. No increase in version will be made when this PR is merged.

@mdtanker mdtanker linked an issue Apr 26, 2024 that may be closed by this pull request
Copy link

🔔 Thank you for raising your pull request.
Version 0.3.3 is already released. No increase in version will be made when this PR is merged.

@mdtanker mdtanker linked an issue Apr 26, 2024 that may be closed by this pull request
@mdtanker mdtanker changed the title Maintenance Edits for JOSS reviews Apr 26, 2024
Copy link

🔔 Thank you for raising your pull request.
Version 0.3.3 is already released. No increase in version will be made when this PR is merged.

Copy link

🔔 Thank you for raising your pull request.
Version 0.3.3 is already released. No increase in version will be made when this PR is merged.

@mdtanker mdtanker mentioned this pull request Apr 26, 2024
@mdtanker mdtanker linked an issue Apr 26, 2024 that may be closed by this pull request
Copy link

🔔 Thank you for raising your pull request.
📦 If merged, this PR will release version 0.4.0-rc.1.

Copy link

🔔 Thank you for raising your pull request.
📦 If merged, this PR will release version 0.4.0-rc.1.

Copy link

🔔 Thank you for raising your pull request.
📦 If merged, this PR will release version 0.4.0-rc.1.

Copy link

🔔 Thank you for raising your pull request.
📦 If merged, this PR will release version 0.4.0-rc.1.

Copy link

🔔 Thank you for raising your pull request.
📦 If merged, this PR will release version 0.4.0-rc.1.

Copy link

🔔 Thank you for raising your pull request.
📦 If merged, this PR will release version 0.4.0-rc.1.

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 11.40741% with 598 lines in your changes missing coverage. Please review.

Project coverage is 30.52%. Comparing base (9a8ae51) to head (53e7032).
Report is 68 commits behind head on main.

Current head 53e7032 differs from pull request most recent head a3df63a

Please upload reports for the commit a3df63a to get more accurate results.

Files Patch % Lines
src/polartoolkit/maps.py 0.34% 286 Missing ⚠️
src/polartoolkit/fetch.py 14.21% 163 Missing ⚠️
src/polartoolkit/utils.py 29.68% 90 Missing ⚠️
src/polartoolkit/profile.py 0.00% 59 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
- Coverage   35.43%   30.52%   -4.92%     
==========================================
  Files           6        6              
  Lines        2627     3119     +492     
==========================================
+ Hits          931      952      +21     
- Misses       1696     2167     +471     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🔔 Thank you for raising your pull request.
📦 If merged, this PR will release version 0.4.0-rc.1.

@mdtanker mdtanker mentioned this pull request Jun 14, 2024
@mdtanker mdtanker closed this Jun 14, 2024
@mdtanker mdtanker deleted the mdtanker-patch-3 branch June 14, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment