Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tqdm dependency missing with conda-forge install #193

Closed
JessicaS11 opened this issue Apr 23, 2024 · 2 comments · Fixed by #212
Closed

tqdm dependency missing with conda-forge install #193

JessicaS11 opened this issue Apr 23, 2024 · 2 comments · Fixed by #212

Comments

@JessicaS11
Copy link

Describe the bug
Tutorial notebooks require a dev install to run (due to missing dependency tqdm).

Full code that generate the error

As part of this JOSS review, I followed the installation instructions for mamba + downloaded the repo using git clone here. However, I DID NOT perform a dev install (pip install .) and attempted to run the docs/tutorial/fetch_walkthrough.ipynb notebook. The first call to fetch (grid = fetch.bedmap2( layer="thickness", verbose="q", ) failed with ValueError: Missing package 'tqdm' required for progress bars..

As a user, I would expect that I can follow the installation instructions, clone the repo (or download a tutorial notebook) and it will run without further environment management or local install. I'm not familiar enough with packaging with pyproject to quickly debug, but it looks like somehow tqdm isn't getting picked up as a dependency during the conda/mamba installation (is it sill default with pooch[progress] as noted in pyproject.toml)?).

mamba create --name polartoolkit --yes --force polartoolkit
git clone https://github.com/mdtanker/polartoolkit.git
Copy link

welcome bot commented Apr 23, 2024

👋 Thanks for opening your first issue here! Please make sure you filled out the template with as much detail as possible. You might also want to take a look at our contributing guidelines.

@JessicaS11 JessicaS11 changed the title Clarify installation instructions for interactive features and update dependencies tqdm dependency missing with conda-forge install Apr 23, 2024
@mdtanker mdtanker linked a pull request Apr 26, 2024 that will close this issue
@mdtanker
Copy link
Owner

mdtanker commented Apr 26, 2024

Thanks for opening this. That is strange that tqdm isn't being included. I will explicitly add it as a required dependency. Will be fixed as part of #212 .

@mdtanker mdtanker linked a pull request Jun 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants