Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] [jsk_maps] Add change-floor server to change map #1251

Merged
merged 14 commits into from
Jul 2, 2019

Conversation

iory
Copy link
Member

@iory iory commented Nov 7, 2018

No description provided.

(let ((current-costmap-publish-frequency
(ros::get-param (format nil "~A/~A/publish_frequency"
*move-base-node* *costmap-name*))))
(unix::usleep (* 1000 1000))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(unix:sleep 1)?

@@ -0,0 +1,49 @@
#!/usr/bin/env roseus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file seems to be a module. Need to be executable?

(defun change-floor (target-floor
&key
(floor-frame "/map")
(topicname "/inamenitialpose3d")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(topicname "/initialpose3d")?

@iory
Copy link
Member Author

iory commented Nov 8, 2018

@YutoUchimi
Thanks for your review! I fixed the code with reference to your review.

@k-okada
Copy link
Member

k-okada commented Nov 15, 2018

why you need this node ? Is current demo code not able to change the floor ?

@iory iory changed the title [jsk_maps] Add change-floor server to change map [wip] [jsk_maps] Add change-floor server to change map Nov 16, 2018
@iory
Copy link
Member Author

iory commented Nov 16, 2018

In current demo code, changes the floor function only supports for pr2.
For movable robot like fetch and aero, we supports change floor node in jsk_maps.

@k-okada k-okada merged commit 4bed13e into jsk-ros-pkg:master Jul 2, 2019
@k-okada
Copy link
Member

k-okada commented Jun 16, 2022

@iory can you fix pr2 robot to use change-fllor-server.l ? I am afraid we have to maintain two code for same functionality #1359

@iory
Copy link
Member Author

iory commented Jul 27, 2022

OK. I'll change it to use change-floor-server.l.

@iory iory deleted the change-floor branch July 27, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants