-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ign -> gz : ros_gz Migration (Move Packages) #282
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 25, 2022
methylDragon
force-pushed
the
ros_gz_migration-mv
branch
from
July 25, 2022 23:17
7a4ad43
to
190f83c
Compare
methylDragon
force-pushed
the
ros_gz_migration-mv
branch
2 times, most recently
from
July 25, 2022 23:59
964ee1b
to
9f3be25
Compare
methylDragon
force-pushed
the
ros_gz_migration-mv
branch
2 times, most recently
from
July 27, 2022 07:18
ea86099
to
9d4236c
Compare
methylDragon
force-pushed
the
ros_gz_migration-mv
branch
7 times, most recently
from
August 1, 2022 20:23
c305a3c
to
1f936b9
Compare
chapulina
reviewed
Aug 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we shouldn't merge this until #281 is ready. I'll review that one next.
methylDragon
force-pushed
the
ros_gz_migration-mv
branch
from
August 17, 2022 00:14
2b560e2
to
fa9cf16
Compare
Signed-off-by: methylDragon <[email protected]>
Clean up shared libraries, and tick-tock RosGzPointCloud Tick-tock launch args Hard-tock ign_ in sources Migrate ign, ign_, IGN_ for sources, launch, and test files Migrate IGN_XXX_VER, IGN_T, header guards Migrate launchfile, launchfile args, and test source references Migrate ros_ign_XXX and gz_gazebo -> gz_sim Migrate ros_ign_XXX project names Migrate Ign, ign-, IGN_DEPS, ign-gazebo Migrate ignitionrobotics, ignitionrobotics/ros_ign, osrf/ros_ign Migrate ignition-version, IGNITION_VERSION, Ignition <LIB>, ros_ign_ci Signed-off-by: methylDragon <[email protected]>
methylDragon
force-pushed
the
ros_gz_migration-mv
branch
from
August 17, 2022 00:14
fa9cf16
to
07bca97
Compare
chapulina
approved these changes
Aug 17, 2022
methylDragon
added a commit
that referenced
this pull request
Aug 17, 2022
Signed-off-by: methylDragon <[email protected]>
mjcarroll
pushed a commit
that referenced
this pull request
Sep 22, 2022
Signed-off-by: methylDragon <[email protected]>
mjcarroll
pushed a commit
that referenced
this pull request
Sep 22, 2022
Clean up shared libraries, and tick-tock RosGzPointCloud Tick-tock launch args Hard-tock ign_ in sources Migrate ign, ign_, IGN_ for sources, launch, and test files Migrate IGN_XXX_VER, IGN_T, header guards Migrate launchfile, launchfile args, and test source references Migrate ros_ign_XXX and gz_gazebo -> gz_sim Migrate ros_ign_XXX project names Migrate Ign, ign-, IGN_DEPS, ign-gazebo Migrate ignitionrobotics, ignitionrobotics/ros_ign, osrf/ros_ign Migrate ignition-version, IGNITION_VERSION, Ignition <LIB>, ros_ign_ci Signed-off-by: methylDragon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #262
BREAKING, AND MUST BE REBASED
Migrates: