Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz : ros_gz Migration (Shims) #281

Merged
merged 3 commits into from
Aug 17, 2022
Merged

ign -> gz : ros_gz Migration (Shims) #281

merged 3 commits into from
Aug 17, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon commented Jul 25, 2022 •
edited
Loading

Part of: #262

Implements shim packages.
These are EXPECTED TO FAIL (until the move PR is in) since it'll result in duplicate packages.

@methylDragon methylDragon mentioned this pull request Jul 25, 2022
Closed
4 tasks
@chapulina chapulina added ROS 2 ROS 2 ign to gz Renaming Ignition to Gazebo. labels Jul 26, 2022
@methylDragon methylDragon force-pushed the ros_gz_migration-shims branch 11 times, most recently from 30a0c3b to 75c5828 Compare August 1, 2022 20:24
@chapulina chapulina changed the base branch from ros2 to ros_gz_migration-mv August 10, 2022 19:39
chapulina
chapulina suggested changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done with the shims! I have some comments below, and I'm wondering if we can avoid duplicating the messages somehow 🤔

ros_gz_shims/README.md Outdated Show resolved Hide resolved
ros_gz_shims/ros_ign/README.md Outdated Show resolved Hide resolved
ros_gz_shims/ros_ign/package.xml Outdated Show resolved Hide resolved
ros_gz_shims/ros_ign/package.xml Outdated Show resolved Hide resolved
ros_gz_shims/ros_ign/package.xml Outdated Show resolved Hide resolved
ros_gz_shims/ros_ign_gazebo/launch/ign_gazebo.launch.py.in Show resolved Hide resolved
ros_gz_shims/ros_ign_gazebo/src/create_shim.cpp Show resolved Hide resolved
ros_gz_shims/ros_ign_gazebo/src/create_shim.cpp Outdated Show resolved Hide resolved
ros_gz_shims/ros_ign_gazebo_demos/launch/image_bridge.launch.py Show resolved Hide resolved
ros_gz_shims/ros_ign_image/src/image_bridge_shim.cpp Outdated Show resolved Hide resolved
@methylDragon methylDragon force-pushed the ros_gz_migration-shims branch 2 times, most recently from c79ba8b to da80ba7 Compare August 11, 2022 18:37
chapulina
chapulina suggested changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just some smaller comments. Also need to fix DCO.

I think the Garden failures are due to improperly built debs upstream building gz-sim version 8 instead of 7. It should have been fixed since gazebo-tooling/release-tools#790. I've rerun the DSL and retriggered nightlies:

  • Jammy Build Status

ros_gz_shims/ros_ign_gazebo/CMakeLists.txt Show resolved Hide resolved
ros_gz_shims/ros_ign_gazebo_demos/launch/gpu_lidar.launch.py Outdated Show resolved Hide resolved
ros_gz_shims/ros_ign_interfaces/README.md Outdated Show resolved Hide resolved
ros_gz_shims/ros_ign_gazebo_demos/README.md Outdated Show resolved Hide resolved
@methylDragon methylDragon force-pushed the ros_gz_migration-shims branch 2 times, most recently from b11d1e3 to a5ef580 Compare August 12, 2022 22:26
@methylDragon
Copy link
Contributor Author

DCO fixed!

@methylDragon methylDragon force-pushed the ros_gz_migration-mv branch 2 times, most recently from fa9cf16 to 07bca97 Compare August 17, 2022 00:14
Base automatically changed from ros_gz_migration-mv to ros2 August 17, 2022 01:55
methylDragon and others added 3 commits August 17, 2022 12:12
@methylDragon
Implement shims
ef5ca54 
Signed-off-by: methylDragon <[email protected]>
@methylDragon @chapulina
Refine ros_gz_shims
2ddd614 
Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: methylDragon <[email protected]>
@chapulina @methylDragon
flake8
fcd7b63 
Signed-off-by: Louise Poubel <[email protected]>
@methylDragon methylDragon merged commit 4e6ec6f into ros2 Aug 17, 2022
@methylDragon methylDragon deleted the ros_gz_migration-shims branch August 17, 2022 21:13
mjcarroll pushed a commit that referenced this pull request Sep 22, 2022
@methylDragon @chapulina @mjcarroll
ign -> gz : ros_gz Migration (Shims) (#281)
5b231bc 
Co-authored-by: Louise Poubel <[email protected]>
samagalhaes pushed a commit to samagalhaes/ros_gz that referenced this pull request Sep 23, 2022
@methylDragon @chapulina @samagalhaes
ign -> gz : ros_gz Migration (Shims) (gazebosim#281)
a86535c 
Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Sandro Magalhães <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
ign to gz Renaming Ignition to Gazebo. ROS 2 ROS 2
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@methylDragon @ahcorde @chapulina