Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign -> gz : ros_gz Migration #262

Closed
wants to merge 2 commits into from
Closed

ign -> gz : ros_gz Migration #262

wants to merge 2 commits into from

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon commented Jun 22, 2022

REBASE MERGE THIS!! Files have moved!!

Part of: gazebo-tooling/release-tools#698

This is a two-parter:

  1. Migrate ros_ign -> ros_gz
  2. Leave behind a shim ros_ign that redirects the following to ros_gz:
    • Launchfiles
    • Executables
    • Libraries?
    • CMake variables

Ideally, the shim should be resolvable via rosdep, CMake, and apt, and pull in ros_gz functionality.

Split PRs

Targeted PRs

Notes

  • To make things easier to backport, this does NOT migrate the headers pulled in (ignition/XXX), or the namespaces (ignition::), or anything relating to the core Gazebo (gz) libraries.

⚠️ Rebase-merge this!! There are files moved!
When it's time to, and everything is ok, I'll probably squash everything after the move commit to a single commit so we don't dirty the main commit history.

@chapulina chapulina added ROS 2 ROS 2 ign to gz Renaming Ignition to Gazebo. labels Jun 23, 2022
@methylDragon methylDragon changed the title ign -> gz : ros_gz ign -> gz : ros_gz Migration Jun 24, 2022
RELEASING.md Outdated Show resolved Hide resolved
Signed-off-by: methylDragon <[email protected]>
@methylDragon methylDragon force-pushed the ros_gz_migration branch 7 times, most recently from 1c075d0 to f97885a Compare July 22, 2022 17:53
@methylDragon methylDragon marked this pull request as ready for review July 22, 2022 17:54
@methylDragon methylDragon force-pushed the ros_gz_migration branch 3 times, most recently from a9c7e7b to 506aa58 Compare July 25, 2022 21:22
@methylDragon methylDragon force-pushed the ros_gz_migration branch 3 times, most recently from 3725f02 to 8cdfc2e Compare July 25, 2022 21:57
@methylDragon methylDragon force-pushed the ros_gz_migration branch 2 times, most recently from f8510b8 to 9a6c880 Compare July 25, 2022 23:01
Clean up shared libraries, and tick-tock RosGzPointCloud
Tick-tock launch args
Hard-tock ign_ in sources
Migrate ign, ign_, IGN_ for sources, launch, and test files
Migrate IGN_XXX_VER, IGN_T, header guards
Migrate launchfile, launchfile args, and test source references
Migrate ros_ign_XXX and gz_gazebo -> gz_sim
Migrate ros_ign_XXX project names
Migrate Ign, ign-, IGN_DEPS, ign-gazebo
Migrate ignitionrobotics, ignitionrobotics/ros_ign, osrf/ros_ign
Migrate ignition-version, IGNITION_VERSION, Ignition <LIB>, ros_ign_ci

Signed-off-by: methylDragon <[email protected]>
@methylDragon
Copy link
Contributor Author

Constituent PRs are merged, closing!

@methylDragon methylDragon deleted the ros_gz_migration branch August 22, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ign to gz Renaming Ignition to Gazebo. ROS 2 ROS 2
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants