Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cone as a primitive parametric shape. #638

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

bperseghetti
Copy link
Member

@bperseghetti bperseghetti commented May 13, 2024

🦟 Bug fix

Summary

This helps add the missing cone geometry for primitive/basic parametric shapes:

conetopple
cone

And is also valuable for visualizations of emitters/source that typically have conic-based spread as seen in this acoustic attack on an IMU by showing the affected area:

drone_attack

Associated PRs:

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label May 13, 2024
include/gz/physics/ConeShape.hh Outdated Show resolved Hide resolved
include/gz/physics/ConeShape.hh Show resolved Hide resolved
include/gz/physics/ConeShape.hh Show resolved Hide resolved
include/gz/physics/detail/ConeShape.hh Outdated Show resolved Hide resolved
@bperseghetti bperseghetti marked this pull request as ready for review May 14, 2024 06:39
@bperseghetti bperseghetti changed the title WIP: Cone Add Cone as a primitive parametric shape. May 14, 2024
@bperseghetti bperseghetti requested a review from ahcorde May 14, 2024 06:40
@bperseghetti
Copy link
Member Author

bperseghetti commented May 14, 2024

I took @mjcarroll advice and used mesh of cone for the collision instead of attempting to add it into dart.
Seen with changes here: 078395d

Signed-off-by: Benjamin Perseghetti <[email protected]>
Signed-off-by: Benjamin Perseghetti <[email protected]>
@azeey
Copy link
Contributor

azeey commented Jun 25, 2024

We usually Rebase and merge for backports, but since this has multiple commits, I'll do a squash merge and update the PR title.

@azeey azeey merged commit 12d589b into gazebosim:gz-physics7 Jun 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants