Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cone as a primitive parametric shape. #441

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

bperseghetti
Copy link
Member

@bperseghetti bperseghetti commented May 13, 2024

🦟 Bug fix

Summary

This helps add the missing cone geometry for primitive/basic parametric shapes:

conetopple
cone

And is also valuable for visualizations of emitters/source that typically have conic-based spread as seen in this acoustic attack on an IMU by showing the affected area:

drone_attack

Associated PRs:

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 97.86%. Comparing base (1939fb0) to head (fda8ba8).
Report is 11 commits behind head on gz-msgs10.

Current head fda8ba8 differs from pull request most recent head 34eab63

Please upload reports for the commit 34eab63 to get more accurate results.

Files Patch % Lines
core/include/gz/msgs/convert/GeometryType.hh 20.00% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           gz-msgs10     #441      +/-   ##
=============================================
- Coverage      98.19%   97.86%   -0.34%     
=============================================
  Files             27       27              
  Lines           1166     1171       +5     
=============================================
+ Hits            1145     1146       +1     
- Misses            21       25       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bperseghetti
Copy link
Member Author

@azeey @caguero @ahcorde this is now the backport that needs to get in and be released.

@azeey azeey merged commit dd20923 into gazebosim:gz-msgs10 Jun 18, 2024
9 checks passed
@bperseghetti bperseghetti deleted the pr-cone branch June 21, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants