Add .sh env hook for setting GZ_CONFIG_PATH #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Wiebe Neufeldt <[email protected]>
|
@azeey Is the CI for this package working correctly? The above failure seems unrelated to these changes. |
|
The Jazzy build shouldn't be running for this branch. Fix in ros/rosdistro#43231 |
azeey
requested changes
Oct 17, 2024
There was a problem hiding this comment.
The approach seems good to me, but this file is automatically generated and should not be modified directly. Could you please close this PR and open one on https://github.com/gazebo-tooling/gz_vendor?
|
Ah, I didn't realize these were all automatically generated. I've opened a new PR on the other repo as requested: gazebo-tooling/gz_vendor#11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For systems not using colcon's or ament's
.dsvfiles for initializing the environment, having only "dummy".shhooks means that theGZ_CONFIG_PATHenvironment variable does not get set correctly. The proposed change is to define a "real".shhook with the proper logic to initialize the environment.The same issue applies to many of the
gz_*_vendorpackages and I can create similar PRs for them, but wanted to get feedback from maintainers first to avoid potential spamming.