[Logs] Cleaning code from debug logs #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit: * removes redundant debug logs * changes some valuable debug logs into LOGI level * changes some logs to LOGW level This commit is a part of flutter-tizen#101
|
Don't we need to implement the |
|
@swift-kim at first I didn't understand that the implementation is missing. Please check if my latest commit meets your expectations. |
|
@pkosko Yes, I was expecting that kind of thing as a prerequisite. Thank you for understanding. You may just rename |
All logs are filtered via flag usage: * flutter-tizen run --verbose-system-logs all logs are visible in flutter console, including INFO * flutter-tizen run only ERROR logs are visible in console Related to flutter-tizen#101
pkosko
force-pushed
the
debug_logs_cleaning
branch
from
b9adc91
to
e831358
Compare
swift-kim
reviewed
Jun 14, 2021
rwalczyna
reviewed
Jun 14, 2021
pkosko
force-pushed
the
debug_logs_cleaning
branch
from
24f953c
to
d716883
Compare
swift-kim
approved these changes
Jun 14, 2021
* remove some redundant logs * change some meaningful logs to LOGI or LOGW This commit is a part of flutter-tizen#101
rwalczyna
approved these changes
Jun 15, 2021
swift-kim
reviewed
Jun 15, 2021
pkosko
force-pushed
the
debug_logs_cleaning
branch
from
6459aa3
to
2c995a2
Compare
swift-kim
pushed a commit
that referenced
this pull request
Jun 16, 2021
* [Logs] Cleaning code from debug logs This commit: * removes redundant debug logs * changes some valuable debug logs into LOGI level * changes some logs to LOGW level This commit is a part of #101 * [Logging] Added verbose-system-logs handling All logs are filtered via flag usage: * flutter-tizen run --verbose-system-logs all logs are visible in flutter console, including INFO * flutter-tizen run only ERROR logs are visible in console Related to #101 * Fixes after review * Review fixes 2 * [Logs] Clean remaining LOGD from code * remove some redundant logs * change some meaningful logs to LOGI or LOGW This commit is a part of #101 * Review fixes
swift-kim
pushed a commit
that referenced
this pull request
Sep 27, 2021
* [Logs] Cleaning code from debug logs This commit: * removes redundant debug logs * changes some valuable debug logs into LOGI level * changes some logs to LOGW level This commit is a part of #101 * [Logging] Added verbose-system-logs handling All logs are filtered via flag usage: * flutter-tizen run --verbose-system-logs all logs are visible in flutter console, including INFO * flutter-tizen run only ERROR logs are visible in console Related to #101 * Fixes after review * Review fixes 2 * [Logs] Clean remaining LOGD from code * remove some redundant logs * change some meaningful logs to LOGI or LOGW This commit is a part of #101 * Review fixes
swift-kim
pushed a commit
that referenced
this pull request
Nov 14, 2021
* [Logs] Cleaning code from debug logs This commit: * removes redundant debug logs * changes some valuable debug logs into LOGI level * changes some logs to LOGW level This commit is a part of #101 * [Logging] Added verbose-system-logs handling All logs are filtered via flag usage: * flutter-tizen run --verbose-system-logs all logs are visible in flutter console, including INFO * flutter-tizen run only ERROR logs are visible in console Related to #101 * Fixes after review * Review fixes 2 * [Logs] Clean remaining LOGD from code * remove some redundant logs * change some meaningful logs to LOGI or LOGW This commit is a part of #101 * Review fixes
swift-kim
pushed a commit
that referenced
this pull request
Dec 9, 2021
* [Logs] Cleaning code from debug logs This commit: * removes redundant debug logs * changes some valuable debug logs into LOGI level * changes some logs to LOGW level This commit is a part of #101 * [Logging] Added verbose-system-logs handling All logs are filtered via flag usage: * flutter-tizen run --verbose-system-logs all logs are visible in flutter console, including INFO * flutter-tizen run only ERROR logs are visible in console Related to #101 * Fixes after review * Review fixes 2 * [Logs] Clean remaining LOGD from code * remove some redundant logs * change some meaningful logs to LOGI or LOGW This commit is a part of #101 * Review fixes
swift-kim
pushed a commit
that referenced
this pull request
Dec 17, 2021
* [Logs] Cleaning code from debug logs This commit: * removes redundant debug logs * changes some valuable debug logs into LOGI level * changes some logs to LOGW level This commit is a part of #101 * [Logging] Added verbose-system-logs handling All logs are filtered via flag usage: * flutter-tizen run --verbose-system-logs all logs are visible in flutter console, including INFO * flutter-tizen run only ERROR logs are visible in console Related to #101 * [Logs] Clean remaining LOGD from code * remove some redundant logs * change some meaningful logs to LOGI or LOGW This commit is a part of #101 * Review fixes
swift-kim
pushed a commit
that referenced
this pull request
Feb 7, 2022
* [Logs] Cleaning code from debug logs This commit: * removes redundant debug logs * changes some valuable debug logs into LOGI level * changes some logs to LOGW level This commit is a part of #101 * [Logging] Added verbose-system-logs handling All logs are filtered via flag usage: * flutter-tizen run --verbose-system-logs all logs are visible in flutter console, including INFO * flutter-tizen run only ERROR logs are visible in console Related to #101 * [Logs] Clean remaining LOGD from code * remove some redundant logs * change some meaningful logs to LOGI or LOGW This commit is a part of #101 * Review fixes
swift-kim
pushed a commit
that referenced
this pull request
Feb 11, 2022
* [Logs] Cleaning code from debug logs This commit: * removes redundant debug logs * changes some valuable debug logs into LOGI level * changes some logs to LOGW level This commit is a part of #101 * [Logging] Added verbose-system-logs handling All logs are filtered via flag usage: * flutter-tizen run --verbose-system-logs all logs are visible in flutter console, including INFO * flutter-tizen run only ERROR logs are visible in console Related to #101 * [Logs] Clean remaining LOGD from code * remove some redundant logs * change some meaningful logs to LOGI or LOGW This commit is a part of #101 * Review fixes
swift-kim
pushed a commit
that referenced
this pull request
May 12, 2022
* [Logs] Cleaning code from debug logs This commit: * removes redundant debug logs * changes some valuable debug logs into LOGI level * changes some logs to LOGW level This commit is a part of #101 * [Logging] Added verbose-system-logs handling All logs are filtered via flag usage: * flutter-tizen run --verbose-system-logs all logs are visible in flutter console, including INFO * flutter-tizen run only ERROR logs are visible in console Related to #101 * [Logs] Clean remaining LOGD from code * remove some redundant logs * change some meaningful logs to LOGI or LOGW This commit is a part of #101 * Review fixes
swift-kim
pushed a commit
that referenced
this pull request
Aug 5, 2022
* [Logs] Cleaning code from debug logs This commit: * removes redundant debug logs * changes some valuable debug logs into LOGI level * changes some logs to LOGW level * [Logging] Added verbose-system-logs handling All logs are filtered via flag usage: * flutter-tizen run --verbose-system-logs all logs are visible in flutter console, including INFO * flutter-tizen run only ERROR logs are visible in console * [Logs] Clean remaining LOGD from code * remove some redundant logs * change some meaningful logs to LOGI or LOGW
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
* [Logs] Cleaning code from debug logs This commit: * removes redundant debug logs * changes some valuable debug logs into LOGI level * changes some logs to LOGW level * [Logging] Added verbose-system-logs handling All logs are filtered via flag usage: * flutter-tizen run --verbose-system-logs all logs are visible in flutter console, including INFO * flutter-tizen run only ERROR logs are visible in console * [Logs] Clean remaining LOGD from code * remove some redundant logs * change some meaningful logs to LOGI or LOGW
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit:
This commit does the work needed for #101