Skip to content

Commit

Permalink
Review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
pkosko committed Jun 15, 2021
1 parent d3d5ab9 commit 6459aa3
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
6 changes: 3 additions & 3 deletions shell/platform/tizen/external_texture_surface_gl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -55,20 +55,20 @@ bool ExternalTextureSurfaceGL::PopulateTexture(
const FlutterDesktopGpuBuffer* gpu_buffer =
texture_callback_(width, height, user_data_);
if (!gpu_buffer) {
FT_LOGE("[texture id:%ld] gpu_buffer is null", texture_id_);
FT_LOGI("[texture id:%ld] gpu_buffer is null", texture_id_);
return false;
}

if (!gpu_buffer->buffer) {
FT_LOGE("[texture id:%ld] tbm_surface_ is null", texture_id_);
FT_LOGI("[texture id:%ld] tbm_surface_ is null", texture_id_);
return false;
}
const tbm_surface_h tbm_surface =
reinterpret_cast<tbm_surface_h>(const_cast<void*>(gpu_buffer->buffer));

tbm_surface_info_s info;
if (tbm_surface_get_info(tbm_surface, &info) != TBM_SURFACE_ERROR_NONE) {
FT_LOGE("[texture id:%ld] tbm_surface is invalid", texture_id_);
FT_LOGI("[texture id:%ld] tbm_surface is invalid", texture_id_);
return false;
}

Expand Down
2 changes: 1 addition & 1 deletion shell/platform/tizen/tizen_log.h
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,6 @@ log_priority GetMinLoggingLevel();
#define FT_COMPILE_ASSERT(exp, name) static_assert((exp), #name)
#endif

#define FT_UNIMPLEMENTED() FT_LOGD("UNIMPLEMENTED!")
#define FT_UNIMPLEMENTED() FT_LOGW("UNIMPLEMENTED!")

#endif // EMBEDDER_TIZEN_LOG_H_
1 change: 0 additions & 1 deletion shell/platform/tizen/tizen_vsync_waiter.cc
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ void TizenVsyncWaiter::RequestVblankLoop(void* data, Ecore_Thread* thread) {
continue;
}
if (msg->value == QUEUE_QUIT) {
FT_LOGE("Message queue quit");
return;
}
if (!tizen_vsync_waiter->TDMValid()) {
Expand Down

0 comments on commit 6459aa3

Please sign in to comment.