Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the logging system #101

Closed
swift-kim opened this issue May 30, 2021 · 1 comment
Closed

Improve the logging system #101

swift-kim opened this issue May 30, 2021 · 1 comment
Assignees
@pkosko
Labels
enhancement New feature or request

Comments

@swift-kim
Copy link
Member

Previous discussion: #75 (comment)

  • The embedder should properly control its logging level based on the verbose_logging switch (which is enabled by flutter-tizen run --verbose-system-logs).
    • Example:

      engine/shell/common/shell.cc

      Lines 228 to 231 in 9f08d18

      fml::LogSettings log_settings;
      log_settings.min_log_level =
      settings.verbose_logging ? fml::LOG_INFO : fml::LOG_ERROR;
      fml::SetLogSettings(log_settings);
  • Remove unnecessary logs in the embedder or make them more informative. We should remove all occurrences of FT_LOGD and use only FT_LOGI/W/E.
@swift-kim swift-kim added the enhancement New feature or request label May 30, 2021
@pkosko pkosko self-assigned this Jun 7, 2021
pkosko added a commit to pkosko/engine that referenced this issue Jun 9, 2021
@pkosko
[Logs] Cleaning code from debug logs
1e4a64d 
This commit:
* removes redundant debug logs
* changes some valuable debug logs into LOGI level
* changes some logs to LOGW level

This commit is a part of flutter-tizen#101
pkosko added a commit to pkosko/engine that referenced this issue Jun 9, 2021
@pkosko
[Logs] Cleaning code from debug logs
1cd3f24 
This commit:
* removes redundant debug logs
* changes some valuable debug logs into LOGI level
* changes some logs to LOGW level

This commit is a part of flutter-tizen#101
This was referenced Jun 9, 2021
Closed
Merged
pkosko added a commit to pkosko/engine that referenced this issue Jun 14, 2021
@pkosko
[Logging] Added verbose-system-logs handling
b9adc91 
All logs are filtered via flag usage:

* flutter-tizen run --verbose-system-logs
  all logs are visible in flutter console, including INFO
* flutter-tizen run
  only ERROR logs are visible in console

Related to flutter-tizen#101
pkosko added a commit to pkosko/engine that referenced this issue Jun 14, 2021
@pkosko
[Logging] Added verbose-system-logs handling
e831358 
All logs are filtered via flag usage:

* flutter-tizen run --verbose-system-logs
  all logs are visible in flutter console, including INFO
* flutter-tizen run
  only ERROR logs are visible in console

Related to flutter-tizen#101
pkosko added a commit to pkosko/engine that referenced this issue Jun 15, 2021
@pkosko
[Logs] Clean remaining LOGD from code
d3d5ab9 
* remove some redundant logs
* change some meaningful logs to LOGI or LOGW

This commit is a part of flutter-tizen#101
swift-kim pushed a commit that referenced this issue Jun 16, 2021
@pkosko
[Logs] Cleaning code from debug logs (#108)
fdd03a6 
* [Logs] Cleaning code from debug logs

This commit:
* removes redundant debug logs
* changes some valuable debug logs into LOGI level
* changes some logs to LOGW level

This commit is a part of #101

* [Logging] Added verbose-system-logs handling

All logs are filtered via flag usage:

* flutter-tizen run --verbose-system-logs
  all logs are visible in flutter console, including INFO
* flutter-tizen run
  only ERROR logs are visible in console

Related to #101

* Fixes after review

* Review fixes 2

* [Logs] Clean remaining LOGD from code

* remove some redundant logs
* change some meaningful logs to LOGI or LOGW

This commit is a part of #101

* Review fixes
swift-kim pushed a commit that referenced this issue Jun 16, 2021
@pkosko @swift-kim
[Logs] Cleaning code from debug logs (#108)
4d5cc82 
* [Logs] Cleaning code from debug logs

This commit:
* removes redundant debug logs
* changes some valuable debug logs into LOGI level
* changes some logs to LOGW level

This commit is a part of #101

* [Logging] Added verbose-system-logs handling

All logs are filtered via flag usage:

* flutter-tizen run --verbose-system-logs
  all logs are visible in flutter console, including INFO
* flutter-tizen run
  only ERROR logs are visible in console

Related to #101

* Fixes after review

* Review fixes 2

* [Logs] Clean remaining LOGD from code

* remove some redundant logs
* change some meaningful logs to LOGI or LOGW

This commit is a part of #101

* Review fixes
@swift-kim
Copy link
Member Author

Fixed by #108. Thanks to @pkosko.

swift-kim pushed a commit that referenced this issue Sep 27, 2021
@pkosko @swift-kim
[Logs] Cleaning code from debug logs (#108)
1e810ed 
* [Logs] Cleaning code from debug logs

This commit:
* removes redundant debug logs
* changes some valuable debug logs into LOGI level
* changes some logs to LOGW level

This commit is a part of #101

* [Logging] Added verbose-system-logs handling

All logs are filtered via flag usage:

* flutter-tizen run --verbose-system-logs
  all logs are visible in flutter console, including INFO
* flutter-tizen run
  only ERROR logs are visible in console

Related to #101

* Fixes after review

* Review fixes 2

* [Logs] Clean remaining LOGD from code

* remove some redundant logs
* change some meaningful logs to LOGI or LOGW

This commit is a part of #101

* Review fixes
swift-kim pushed a commit that referenced this issue Nov 14, 2021
@pkosko @swift-kim
[Logs] Cleaning code from debug logs (#108)
4ad0864 
* [Logs] Cleaning code from debug logs

This commit:
* removes redundant debug logs
* changes some valuable debug logs into LOGI level
* changes some logs to LOGW level

This commit is a part of #101

* [Logging] Added verbose-system-logs handling

All logs are filtered via flag usage:

* flutter-tizen run --verbose-system-logs
  all logs are visible in flutter console, including INFO
* flutter-tizen run
  only ERROR logs are visible in console

Related to #101

* Fixes after review

* Review fixes 2

* [Logs] Clean remaining LOGD from code

* remove some redundant logs
* change some meaningful logs to LOGI or LOGW

This commit is a part of #101

* Review fixes
swift-kim pushed a commit that referenced this issue Dec 9, 2021
@pkosko @swift-kim
[Logs] Cleaning code from debug logs (#108)
10bce6e 
* [Logs] Cleaning code from debug logs

This commit:
* removes redundant debug logs
* changes some valuable debug logs into LOGI level
* changes some logs to LOGW level

This commit is a part of #101

* [Logging] Added verbose-system-logs handling

All logs are filtered via flag usage:

* flutter-tizen run --verbose-system-logs
  all logs are visible in flutter console, including INFO
* flutter-tizen run
  only ERROR logs are visible in console

Related to #101

* Fixes after review

* Review fixes 2

* [Logs] Clean remaining LOGD from code

* remove some redundant logs
* change some meaningful logs to LOGI or LOGW

This commit is a part of #101

* Review fixes
swift-kim pushed a commit that referenced this issue Dec 17, 2021
@pkosko @swift-kim
[Logs] Cleaning code from debug logs (#108)
7ba7db3 
* [Logs] Cleaning code from debug logs

This commit:
* removes redundant debug logs
* changes some valuable debug logs into LOGI level
* changes some logs to LOGW level

This commit is a part of #101

* [Logging] Added verbose-system-logs handling

All logs are filtered via flag usage:

* flutter-tizen run --verbose-system-logs
  all logs are visible in flutter console, including INFO
* flutter-tizen run
  only ERROR logs are visible in console

Related to #101

* [Logs] Clean remaining LOGD from code

* remove some redundant logs
* change some meaningful logs to LOGI or LOGW

This commit is a part of #101

* Review fixes
swift-kim pushed a commit that referenced this issue Feb 7, 2022
@pkosko @swift-kim
[Logs] Cleaning code from debug logs (#108)
c5e35a5 
* [Logs] Cleaning code from debug logs

This commit:
* removes redundant debug logs
* changes some valuable debug logs into LOGI level
* changes some logs to LOGW level

This commit is a part of #101

* [Logging] Added verbose-system-logs handling

All logs are filtered via flag usage:

* flutter-tizen run --verbose-system-logs
  all logs are visible in flutter console, including INFO
* flutter-tizen run
  only ERROR logs are visible in console

Related to #101

* [Logs] Clean remaining LOGD from code

* remove some redundant logs
* change some meaningful logs to LOGI or LOGW

This commit is a part of #101

* Review fixes
swift-kim pushed a commit that referenced this issue Feb 11, 2022
@pkosko @swift-kim
[Logs] Cleaning code from debug logs (#108)
d749d36 
* [Logs] Cleaning code from debug logs

This commit:
* removes redundant debug logs
* changes some valuable debug logs into LOGI level
* changes some logs to LOGW level

This commit is a part of #101

* [Logging] Added verbose-system-logs handling

All logs are filtered via flag usage:

* flutter-tizen run --verbose-system-logs
  all logs are visible in flutter console, including INFO
* flutter-tizen run
  only ERROR logs are visible in console

Related to #101

* [Logs] Clean remaining LOGD from code

* remove some redundant logs
* change some meaningful logs to LOGI or LOGW

This commit is a part of #101

* Review fixes
swift-kim pushed a commit that referenced this issue May 12, 2022
@pkosko @swift-kim
[Logs] Cleaning code from debug logs (#108)
c03f3ac 
* [Logs] Cleaning code from debug logs

This commit:
* removes redundant debug logs
* changes some valuable debug logs into LOGI level
* changes some logs to LOGW level

This commit is a part of #101

* [Logging] Added verbose-system-logs handling

All logs are filtered via flag usage:

* flutter-tizen run --verbose-system-logs
  all logs are visible in flutter console, including INFO
* flutter-tizen run
  only ERROR logs are visible in console

Related to #101

* [Logs] Clean remaining LOGD from code

* remove some redundant logs
* change some meaningful logs to LOGI or LOGW

This commit is a part of #101

* Review fixes
swift-kim pushed a commit that referenced this issue Sep 1, 2022
@bdero @dnfield
Render glyphs at the correct resolution with respect to the current t…
0aaa84e 
…ransform (#101)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkosko pkosko

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pkosko @swift-kim