[Logs] Cleaning code from debug logs #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flutter crash reports on Fuchsia are considered non-fatal because they're not filed in response to the termination of the Flutter application, just a Dart exception that was thrown.
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
https://dart.googlesource.com/sdk.git/+log/bc78a79e5e80..c346bb2d834b 2021-03-25 [email protected] Version 2.13.0-166.0.dev 2021-03-25 [email protected] Version 2.13.0-165.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
) https://skia.googlesource.com/skia.git/+log/a6748aa80272..c028c5c1f83e 2021-03-25 [email protected] Revert "Don't reuse scratch textures when texsub image banned for FBO textures" 2021-03-25 [email protected] [infra] Add Test-Mac11-Clang-MacMini9.1-CPU-AppleM1-arm64-Debug-All-NativeFonts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
…ter#25050) * Fixes android voice access delete text, redo, and undo actions * account for unicode
* Current the text input channel handles user input for only existing flutter components. Therefore, we added the logic so that the platform view can also handle the composition events happened by user input.
* Fix typo FlutterDestoryWindow * Remove FlutterRotateWindow
* Enable arm64 build * Update azure-pipelines.yml * Add the common profile
* The return value of TextInputModel::selection is not a reference Signed-off-by: Boram Bae <[email protected]>
* Allow multiple default fonts for localizations * Update fallback fonts from tv profile * Add fonts in wearable and tv emulator + adjust azure pipeline
* Separate binaries * Clean up the build script * Use templates * Use __dlog_print() only on TV * Copy headers and icudata * Partially update azure-pipelines.yml * Temporarily unsupport Tizen 4.0 and use only ecore_wl2 * Cherry-pick "Enable Evas GL direct mode (flutter-tizen#54)" - Cherry-pick the commit from flutter-2.0.1-tizen-dev - Rename FLUTTER_TIZEN_EVASGL with TIZEN_RENDERER_EVAS_GL - Add missing switches and fix build errors Co-authored-by: Boram Bae <[email protected]> Co-authored-by: MuHong Byun <[email protected]> * Fix CI build * Disable Evas GL direct mode and remove use of elm_win_aux_hint_add * Simplify the CI job * A workaround for isIME in Evas GL mode * Refactor: Clean up tizen_renderer.h and re-order functions * Refactor: Rename GetEcoreWindowId and change its return type to uintptr_t * Refactor: Make GetImageHandle() Evas GL-only * Refactor: Additional clean ups * Initialize members properly * Get window id from evas_window_ * Re-format code Co-authored-by: Boram Bae <[email protected]> Co-authored-by: MuHong Byun <[email protected]>
* Increase mouse wheel scroll speed * Suppress error message on app launch
* Add multi touch support for Tizen embedder Tested on TM1 device Signed-off-by: Rafal Walczyna <[email protected]> * Rename multi_touch_device to device_id Signed-off-by: Rafal Walczyna <[email protected]>
…lutter-tizen#72) The screen width/height/dpi values returned by the system_info API are just pre-defined values and do not represent the actual properties of the display. The correct values can be only obtained after ecore_wl2_display is created.
* Add support for running flutter engine without UI Signed-off-by: Rafal Walczyna <[email protected]> * Change surface_present_callback to lambda function Signed-off-by: Rafal Walczyna <[email protected]> * Fix nullptr exception when TIZEN_RENDERER_EVAS_GL was used Signed-off-by: Rafal Walczyna <[email protected]>
…-tizen#79) * [SystemChrome] setPreferredOrientations implementation added [Before] not implemented [After] Using API below allows to narrow some rotations of application UI e.g. /// to limit some orientations List<DeviceOrientation> orientations = [DeviceOrientation.portraitUp, DeviceOrientation.landscapeLeft]; SystemChrome.setPreferredOrientations(orientations).then( (value) => print("preferred orientations were set")); /// to clear previous limitations List<DeviceOrientation> orientations = []; SystemChrome.setPreferredOrientations(orientations).then( (value) => print("preferred orientations were CLEARED")); * [SystemChrome] setPreferredOrientations implementation added - review fixes * [SystemChrome] setPreferredOrientations implementation added - changed member name
* Fix a crash in ExternalTextureGL * Abandon ownership of tbm surface in PopulateTextureWithIdentifier * This patch includes temporary fix for invalid tmb_surface Signed-off-by: Boram Bae <[email protected]> * Include the texture id in the log Signed-off-by: Boram Bae <[email protected]> * Lock the mutex in the external texture related API * Use find instead of operator[] that can cause unintended insertion Signed-off-by: Boram Bae <[email protected]>
* Rename types and functions * Clean up engine APIs * Add FlutterDesktopEngineGetMessenger API * Refactor FlutterTizenEngine a bit * Refactor channels
* [HapticFeedback] Implement vibrate()
[Before] HapticFeedback.vibrate() was not implemented
[After] The code below will cause a short vibration:
HapticFeedback.vibrate()
Signed-off-by: Pawel Wasowski <[email protected]>
* Make HapticFeedback.vibrate's dependencies dependent on profile
HapticFeedback.vibrate will only work on mobile and wearable profiles so
its dependencies should only be included in builds for these devices.
Signed-off-by: Pawel Wasowski <[email protected]>
* Make FeedbackManager a singleton
* [HapticFeedback.vibrate] Minfor fixes
- use the proper "MOBILE_PROFILE" and "WEARABLE_PROFILE" names instead of
"MOBILE" and "WEARABLE"
- reorder lines in BUILD.gn
Signed-off-by: Pawel Wasowski <[email protected]>
* Refactor implementation of HapticFeedback.vibrate() and BUILD.gn
Signed-off-by: Pawel Wasowski <[email protected]>
* [HapticFeedback] Refactor FeedbackManager
Signed-off-by: Pawel Wasowski <[email protected]>
* [HapticFeedback] Use FT_LOGE for all error logs
* [Clipboard] setData and getData implementations added
and also removed code for hasStrings, as this API is not present in documentation.
[Before] Clipboard.setData and Clipboard.getData feature was not implemented
[After] Naive implementation of clipboard shared only inside Flutter application
and only via Clipboard API. Such decision was done because of supporting partial
functionality on all profiles. CBHM API is supported only on mobile and currently
it is not possible to support it in other way.
Dart code below is able to set/get internal clipboard data:
ClipboardData cd = ClipboardData(text: 'some text');
Clipboard.setData(cd);
Future<ClipboardData?> d = Clipboard.getData(Clipboard.kTextPlain);
void dataCallback(ClipboardData? d) {
if (d != null) {
String? text = d.text;
if(text != null) {
print("Clipboard data $text");
}
}
}
d.then(dataCallback);
* [Clipboard] Fixes after review
* Removed unnecessary mutex
* Cleaned temporary logs
….play() (flutter-tizen#84) Signed-off-by: Pawel Wasowski <[email protected]>
* Revert "Revert "Roll FreeType to 2.10.4 (flutter#23666) (flutter#23887)" (flutter-tizen#60)" This reverts commit 582f6fe. * Resolve freetype symbols within the engine binary * Clean up unused build flag
* Format gn files * Format C/C++ files * Update azure-pipelines.yml * Rename the format job
Signed-off-by: Boram Bae <[email protected]>
* Add platfrom surface buffer structor * Texture api change(draft) 1.Delete tizen texture api, use common api, add GpuBufferTexture for gpu buffer. 2.Delete ref/unref tbm_surface code in engine, add destructioncall for delete tbm_surface. 3.Support pixel buffer texture. * Revert code to original * Support GPU buffer texture 1.Implement GPU buffer texture. 2.Remove ref/unref tbm surface code. * Change file permission * Add FlutterDesktopGpuBufferTextureConfig in FlutterDesktopTextureInfo. * Add buffer parameter at Destruction callback * Change class name ExternalTextureGL to ExternalTextureSurfaceGL Class ExternamTextureSurfaceGL handle tbm surface texture render. * Remove not used code * Fix wild pointer issue If plugin call UnregisterTexture, then will remove external texture, But at this time, gpu render is not finish. when gpu render finished, tiggle destruction callback, need check whether external texture pointer is wild pointer * Convert unique_ptr to shared_ptr when create external texture * Code format * Fix arm64 build error * Remove not used file * Remove unnecessary headers * Refactor based on comments 1.Remove not used file. 2.Rename define of head file. 2.Rename of variable. * Refactor based on comments 1.Return nullptr for default case when create external texture. 2.Rename methode name from texture_registrar to GetTextureRegistrar. 3.Change OnCollectTextur to static function. * Fix code review issue 1.Use C++ style casts 2.Rename variable and function, make the code more friendly. 3.Add copyright info. * Fix code review issue 1.Rename static veriable(nextTextureId -> kNextTextureId) 2.Modify comment, make it more clear. 3.Rename function name(FlutterDesktopDestructionCallback) * Fix code review issue * Remove warning log This warning log shouldn't be displayed when launching a headless app.
* Use proc table for embedder APIs * Use the proc table like other platform implementations * Use FlutterEngine as private memeber of FlutterTizenEngine * Only FlutterTizenEngine is dependent on FlutterEngine Signed-off-by: Boram Bae <[email protected]> * Update based on review Signed-off-by: Boram Bae <[email protected]>
* Resolve some linter warnings * Remove TODOs * Resolve google-runtime-references warning
* This is necessary for webview resize. Signed-off-by: MuHong Byun <[email protected]>
This commit: * removes redundant debug logs * changes some valuable debug logs into LOGI level * changes some logs to LOGW level This commit is a part of flutter-tizen#101
|
I changed the default base branch back to flutter-2.0.1-tizen. Sorry for not informing you in advance. |
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit:
This commit is a part of #101 changing files:
Next changes will be provided in next PRs.