Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate reply Comment Form into Comment pattern #1423
Integrate reply Comment Form into Comment pattern #1423
Changes from 40 commits
caa5308
d76856b
746a011
d936a13
f509852
07dba85
65e7b52
e94c3a1
a3c1620
eb002be
49d6f4b
2d9f556
06bca63
232792c
da28af4
15b1bf9
60468ac
5f8f15e
06537d3
b226ba5
713077e
96348bc
cee3a46
5ef0f0c
d4952b8
d159cc8
e7dd9da
b8673a3
53e1640
3485aff
aeb1601
5006f41
a3b3174
a81d384
2763ffd
b5ac5c3
118e033
b32ea26
f066e31
ffdbad1
e163efb
f6261a4
bda5f72
fecebe2
80db9f6
70d4a1b
ea636b4
a8a1daf
cf021e7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was tempted to replace this all with a heading block, but that makes it more likely for the
aria-labelledby
relationship between the form and heading to get messed up.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a separate class that does the same thing as
--thread
so our JS doesn't have to handle correctly toggling--thread
and account for whether a comment already has a thread or not.