Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate reply Comment Form into Comment pattern #1423

Merged
merged 49 commits into from
Jul 22, 2021
Merged

Integrate reply Comment Form into Comment pattern #1423

merged 49 commits into from
Jul 22, 2021

Commits on Jul 16, 2021

  1. Rename demo_control

    @Paul-Hebert
    Paul-Hebert committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    caa5308 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2021

  1. Stub out JS/Test files for comments

    @Paul-Hebert
    Paul-Hebert committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    d76856b View commit details
    Browse the repository at this point in the history

  2. Change TS Config target to avoid incorrect warnings

    @Paul-Hebert
    Paul-Hebert committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    746a011 View commit details
    Browse the repository at this point in the history

  3. Fix closing tag

    @Paul-Hebert
    Paul-Hebert committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    d936a13 View commit details
    Browse the repository at this point in the history

  4. Add TS for comments

    @Paul-Hebert
    Paul-Hebert committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    f509852 View commit details
    Browse the repository at this point in the history

  5. Handle spacing

    @Paul-Hebert
    Paul-Hebert committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    07dba85 View commit details
    Browse the repository at this point in the history

  6. Add controls to docs

    @Paul-Hebert
    Paul-Hebert committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    65e7b52 View commit details
    Browse the repository at this point in the history

  7. Update comment generation code

    @Paul-Hebert
    Paul-Hebert committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    e94c3a1 View commit details
    Browse the repository at this point in the history

  8. Add test for comment reply form

    @Paul-Hebert
    Paul-Hebert committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    a3c1620 View commit details
    Browse the repository at this point in the history

  9. Tidy template

    @Paul-Hebert
    Paul-Hebert committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    eb002be View commit details
    Browse the repository at this point in the history

  10. Add accessible names to comment forms

    @Paul-Hebert
    Paul-Hebert committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    49d6f4b View commit details
    Browse the repository at this point in the history

  11. Add template props docs

    @Paul-Hebert
    Paul-Hebert committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    2d9f556 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2021

  1. Add missing props

    @Paul-Hebert
    Paul-Hebert committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    06bca63 View commit details
    Browse the repository at this point in the history

  2. Add code samples

    @Paul-Hebert
    Paul-Hebert committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    232792c View commit details
    Browse the repository at this point in the history

  3. Handle reply heading

    @Paul-Hebert
    Paul-Hebert committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    da28af4 View commit details
    Browse the repository at this point in the history

  4. Move allow_replies outside comment object

    @Paul-Hebert
    Paul-Hebert committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    15b1bf9 View commit details
    Browse the repository at this point in the history

  5. Lint

    @Paul-Hebert
    Paul-Hebert committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    60468ac View commit details
    Browse the repository at this point in the history

  6. Add note about cancel button

    @Paul-Hebert
    Paul-Hebert committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    5f8f15e View commit details
    Browse the repository at this point in the history

  7. Only run JS for comments with replies enabled

    @Paul-Hebert
    Paul-Hebert committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    06537d3 View commit details
    Browse the repository at this point in the history

  8. Fix VoiceOver focus

    @Paul-Hebert
    Paul-Hebert committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    b226ba5 View commit details
    Browse the repository at this point in the history

  9. Add focus test to comments

    @Paul-Hebert
    Paul-Hebert committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    713077e View commit details
    Browse the repository at this point in the history

  10. Lint

    @Paul-Hebert
    Paul-Hebert committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    96348bc View commit details
    Browse the repository at this point in the history

  11. update comment form story

    @Paul-Hebert
    Paul-Hebert committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    cee3a46 View commit details
    Browse the repository at this point in the history

  12. Fix type error

    @Paul-Hebert
    Paul-Hebert committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    5ef0f0c View commit details
    Browse the repository at this point in the history

  13. Tidy

    @Paul-Hebert
    Paul-Hebert committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    d4952b8 View commit details
    Browse the repository at this point in the history

  14. lint

    @Paul-Hebert
    Paul-Hebert committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    d159cc8 View commit details
    Browse the repository at this point in the history

  15. Fix function name mismatch

    @Paul-Hebert
    Paul-Hebert committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    e7dd9da View commit details
    Browse the repository at this point in the history

  16. Another function name mismatch

    @Paul-Hebert
    Paul-Hebert committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    b8673a3 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2021

  1. Remove unnecessary spread

    @Paul-Hebert
    Paul-Hebert committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    53e1640 View commit details
    Browse the repository at this point in the history

  2. Move JS hide/show logic to CSS

    @Paul-Hebert
    Paul-Hebert committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    3485aff View commit details
    Browse the repository at this point in the history

  3. Focus reply button when comment form is closed

    @Paul-Hebert
    Paul-Hebert committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    aeb1601 View commit details
    Browse the repository at this point in the history

  4. Fix iOS focus issue

    @Paul-Hebert
    Paul-Hebert committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    5006f41 View commit details
    Browse the repository at this point in the history

  5. Improve comment

    @Paul-Hebert
    Paul-Hebert committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    a3b3174 View commit details
    Browse the repository at this point in the history

  6. lint

    @Paul-Hebert
    Paul-Hebert committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    a81d384 View commit details
    Browse the repository at this point in the history

  7. Use aria-describedby

    @Paul-Hebert
    Paul-Hebert committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    2763ffd View commit details
    Browse the repository at this point in the history

  8. Make test util for loading global CSS

    @Paul-Hebert
    Paul-Hebert committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    b5ac5c3 View commit details
    Browse the repository at this point in the history

  9. Switch JS setup to single instance method

    @Paul-Hebert
    Paul-Hebert committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    118e033 View commit details
    Browse the repository at this point in the history

  10. Add cleanup methods

    @Paul-Hebert
    Paul-Hebert committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    b32ea26 View commit details
    Browse the repository at this point in the history

  11. Lint

    @Paul-Hebert
    Paul-Hebert committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    f066e31 View commit details
    Browse the repository at this point in the history

  12. Fix code example

    @Paul-Hebert
    Paul-Hebert committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    ffdbad1 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2021

  1. Update src/components/comment-form/comment-form.stories.mdx 

    Co-authored-by: Gerardo Rodriguez <[email protected]>
    @Paul-Hebert @gerardo-rodriguez
    Paul-Hebert and gerardo-rodriguez authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    e163efb View commit details
    Browse the repository at this point in the history

  2. Fix code examples

    @Paul-Hebert
    Paul-Hebert committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    f6261a4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feat/integrate-reply-form' of https://github.com/cloudf… 

    …our/cloudfour.com-patterns into feat/integrate-reply-form
    @Paul-Hebert
    Paul-Hebert committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    bda5f72 View commit details
    Browse the repository at this point in the history

  4. Add changeset

    @Paul-Hebert
    Paul-Hebert committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    fecebe2 View commit details
    Browse the repository at this point in the history

  5. Replace optional chaining with early return

    @Paul-Hebert
    Paul-Hebert committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    80db9f6 View commit details
    Browse the repository at this point in the history

  6. Lint

    @Paul-Hebert
    Paul-Hebert committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    70d4a1b View commit details
    Browse the repository at this point in the history

  7. Update src/components/comment/comment.stories.mdx

    @Paul-Hebert
    Paul-Hebert authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    ea636b4 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/v-next' into feat/integrate-repl… 

    …y-form
    @Paul-Hebert
    Paul-Hebert committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    a8a1daf View commit details
    Browse the repository at this point in the history

  9. Lint

    @Paul-Hebert
    Paul-Hebert committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    cf021e7 View commit details
    Browse the repository at this point in the history