Integrate reply Comment Form into Comment pattern #1423
Conversation
🦋 Changeset detectedLatest commit: cf021e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| - `heading_id`: A unique ID for your heading element. This will be used as the accessible name for the form. | ||
| - `heading_tag`: The tag for your heading (defaults to `h2`). | ||
| - `heading_text`: The text for your heading. | ||
| - `heading_class`: An optional class for your heading. |
There was a problem hiding this comment.
I was tempted to replace this all with a heading block, but that makes it more likely for the aria-labelledby relationship between the form and heading to get messed up.
Paul-Hebert
changed the title
| docs: { | ||
| source: { | ||
| code: makeTwigInclude( | ||
| '@cloudfour/components/comment-form/comment-form.twig', |
There was a problem hiding this comment.
And here? 🤔
| '@cloudfour/components/comment-form/comment-form.twig', | |
| '@cloudfour/components/comment/comment.twig', |
| docs: { | ||
| source: { | ||
| code: makeTwigInclude( | ||
| '@cloudfour/components/comment-form/comment-form.twig', |
There was a problem hiding this comment.
Here too? 🤔
| '@cloudfour/components/comment-form/comment-form.twig', | |
| '@cloudfour/components/comment/comment.twig', |
| docs: { | ||
| source: { | ||
| code: makeTwigInclude( | ||
| '@cloudfour/components/comment-form/comment-form.twig', |
There was a problem hiding this comment.
| '@cloudfour/components/comment-form/comment-form.twig', | |
| '@cloudfour/components/comment/comment.twig', |
| docs: { | ||
| source: { | ||
| code: makeTwigInclude( | ||
| '@cloudfour/components/comment-form/comment-form.twig', |
There was a problem hiding this comment.
| '@cloudfour/components/comment-form/comment-form.twig', | |
| '@cloudfour/components/comment/comment.twig', |
| docs: { | ||
| source: { | ||
| code: makeTwigInclude( | ||
| '@cloudfour/components/comment-form/comment-form.twig', |
There was a problem hiding this comment.
| '@cloudfour/components/comment-form/comment-form.twig', | |
| '@cloudfour/components/comment/comment.twig', |
Co-authored-by: Gerardo Rodriguez <[email protected]>
…our/cloudfour.com-patterns into feat/integrate-reply-form
|
The latest round of feedback has been addressed. Re-review appreciated, thanks! |
There was a problem hiding this comment.
Works much better on small screens! Thanks, @Paul-Hebert! Deferring further design feedback to the separate issues created and deferring approval to @cloudfour/dev since they had more immediate feedback to resolve.
|
@Paul-Hebert It looks like this comment is not resolved? |
Ack, thanks @calebeby , fixed! |
|
Oh no! Since we updated Eslint the lint rules are different in the CI task from what I've got locally. One moment while I resolve this... |
Overview
The primary focus of this PR is integrating the Comment Form for replies into the Comment pattern.
While I was working on this I made some changes to the Comment Form component and updated the code examples for all the Comment stories.
I could use both design + dev review on this.
Follow-up issues will handle:
Screenshots
Testing
isLoggedInandallowRepliescontrols