Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused variables from microphysics methods #15

Merged
merged 2 commits into from
May 18, 2024

Conversation

fmalatino
Copy link
Contributor

@fmalatino fmalatino commented May 14, 2024

Description
Removal of d0_vap and lv00 from sedimentation method calls and cracw from icloud method calls in microphysics.py as they were causing parsing issues

How Has This Been Tested?
Tested using currently implemented translate tests in pySHiELD and in dace:cpu backend runs in pace.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • Targeted model, if this change was triggered by a model need/shortcoming

…and icloud in microphysics.py, which were creating parsing issues
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a double dependency to clear out

setup.py Outdated Show resolved Hide resolved
@fmalatino fmalatino changed the title Removed unused variables, d0_vap, lv00, and cracw from microphysics methods Removed unused variables from microphysics methods May 16, 2024
Copy link
Collaborator

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We should clean up some of the field/constant confusion here, but the new microphysics is coming soon™ anyway, so it's not a huge priority

@fmalatino fmalatino merged commit 5a0846d into NOAA-GFDL:develop May 18, 2024
2 checks passed
@fmalatino fmalatino deleted the fix/unused_vars branch June 4, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants