Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused icloud argument cracw that cause parse failure in orche… #16

Closed
wants to merge 1 commit into from

Conversation

xyuan
Copy link

@xyuan xyuan commented May 17, 2024

…stration mode run

Description
Include a summary of the change and which issue is fixed. Please also include
relevant motivation and context. List any dependencies that are required for
this change.

Fixes # (issue)
If this is a hotfix to a released version, please specify it

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.

Checklist:

  • [y] My code follows the style guidelines of this project
  • [y] I have performed a self-review of my own code
  • [y] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • [y] New check tests, if applicable, are included
  • Targeted model, if this change was triggered by a model need/shortcoming

@xyuan xyuan requested review from fmalatino and oelbert May 17, 2024 18:17
Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's all the same to you I have a draft PR open (PR 15) that is doing this already. I also have two other PRs (one in pyFV3 and NDSL) that are related. Could we use this one instead and close this one?

@bensonr
Copy link

bensonr commented May 17, 2024

It makes sense to consolidate into a single PR. @xyuan - can you redirect this PR into the same source branch as #15?

@xyuan
Copy link
Author

xyuan commented May 17, 2024

close this PR to add this to PR#15

@xyuan xyuan closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants