Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unused variables from microphysics methods #15

Merged
merged 2 commits into from
May 18, 2024
Merged

Removed unused variables from microphysics methods #15

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
545a269
Removed unused variables, d0_vap, lv00, and cracw from sedimentation …
fmalatino May 14, 2024
f2070d1
Removed double dependency for types-PyYAML
fmalatino May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,12 @@ repos:
args: ["--profile", "black"]

- repo: https://github.com/pre-commit/mirrors-mypy
rev: v0.812
rev: v1.4.1
hooks:
- id: mypy
name: mypy-physics
args: [--config-file, setup.cfg]
additional_dependencies: [types-PyYAML]
files: pySHiELD
exclude: |
(?x)^(
Expand Down
6 changes: 0 additions & 6 deletions pySHiELD/stencils/microphysics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,8 +673,6 @@ def sedimentation(
m1_sol: FloatField,
c_air: Float,
c_vap: Float,
d0_vap: Float,
lv00: Float,
log_10: Float,
zs: Float,
dts: Float,
Expand Down Expand Up @@ -1257,7 +1255,6 @@ def icloud(
csaci: Float,
cgacw: Float,
cgaci: Float,
cracw: Float,
cssub_0: Float,
cssub_1: Float,
cssub_2: Float,
Expand Down Expand Up @@ -2101,8 +2098,6 @@ def __call__(self, state: MicrophysicsState, timestep: float):
self._m1_sol,
self._c_air,
self._c_vap,
self._d0_vap,
self._lv00,
self._log_10,
self._zs,
self._dts,
Expand Down Expand Up @@ -2189,7 +2184,6 @@ def __call__(self, state: MicrophysicsState, timestep: float):
self._csaci,
self._cgacw,
self._cgaci,
self._cracw,
self._cssub_0,
self._cssub_1,
self._cssub_2,
Expand Down
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"f90nml>=1.1.0",
"numpy",
"xarray",
"types-pyyaml",
FlorianDeconinck marked this conversation as resolved.
Show resolved Hide resolved
]

test_requirements = ["pytest", "pytest-subtests", "serialbox"]
Expand Down
Loading