Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kinetic] wheel multi controller refactored #140

Merged
merged 1 commit into from
Feb 19, 2018
Merged

[kinetic] wheel multi controller refactored #140

merged 1 commit into from
Feb 19, 2018

Conversation

mathias-luedtke
Copy link
Contributor

@mathias-luedtke mathias-luedtke commented Feb 17, 2017 •
edited by fmessmer
Loading

@mathias-luedtke mathias-luedtke mentioned this pull request Feb 17, 2017
Merged
@fmessmer fmessmer mentioned this pull request Feb 18, 2017
Closed
@fmessmer
Copy link
Contributor

needs more testing and investigation on HW regarding the position control of the steer joints as started in #138

@mathias-luedtke mathias-luedtke force-pushed the feature/wheel-multi-controller-refactored branch from 1e22ff4 to 9d67afb Compare February 22, 2017 14:42
@mathias-luedtke mathias-luedtke changed the title Feature/wheel multi controller refactored [kinetic] wheel multi controller refactored Feb 22, 2017
@mathias-luedtke
Copy link
Contributor Author

rebased on #141

This was referenced Feb 22, 2017
Open
Open
@fmessmer fmessmer self-assigned this Apr 7, 2017
@fmessmer
Copy link
Contributor

Simulation is working under Kinetic (PC setup in my office), thus, we should get back to test and finalize this PR in simulation first...then HW eventually...

@fmessmer fmessmer force-pushed the feature/wheel-multi-controller-refactored branch from 9d67afb to acababc Compare February 14, 2018 17:26
@fmessmer
Copy link
Contributor

remember to specify required_drive_modes for your hardware: ros-industrial/ros_canopen#197

@fmessmer fmessmer mentioned this pull request Feb 14, 2018
Merged
@fmessmer
Copy link
Contributor

@ipa-mdl
I'll merge this...the controller works on cob4-18...we just might need to do some more parmeter tuning...will do this on a new feature PR

@fmessmer fmessmer merged commit c2fd29e into 4am-robotics:kinetic_dev Feb 19, 2018
This was referenced Feb 21, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmessmer fmessmer fmessmer approved these changes

Assignees

@fmessmer fmessmer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathias-luedtke @fmessmer