-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twist controller extensions #110
Changes from all commits
f3162f1
61e56ae
992054c
9a6def8
abafddb
b6df2ff
3e6257a
e004474
44979e3
3b82a04
7f732e2
864f5e0
1cd9dc9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -51,7 +51,7 @@ class KinematicExtensionBase | |
|
||
virtual bool initExtension() = 0; | ||
virtual KDL::Jacobian adjustJacobian(const KDL::Jacobian& jac_chain) = 0; | ||
virtual JointStates adjustJointStates(const JointStates& joint_states) = 0; | ||
virtual JointStates adjustJointStates(const JointStates& joint_states, const geometry_msgs::Pose& pose, const KDL::Twist& twist) = 0; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. base class has been changed and adapted in all files accordingly, even though @ipa-fxm is this fine for you? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Definitely not! |
||
virtual LimiterParams adjustLimiterParams(const LimiterParams& limiter_params) = 0; | ||
virtual void processResultExtension(const KDL::JntArray& q_dot_ik) = 0; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this. Is this valid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marco had to implement its own fk solver for each link such that he could compute the distances between those links. The distance was computed to the center of the object, but he needed the distance to the surface. So he had to compute the frame_vector for each mesh. This vector represents the distance from the centered point of the object to the point on the surface. By subtracting those two vectors, he obtained the real minimal distance between two links.
Since we replaced this inefficient distance computation to the moveIt distance computation, we automatically obtain the minimal distance to the surface. That's why this is valid and we don't need to subtract anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I haven't seen the moveit-based distance computation fully finalized and pushed - including topic remaps and testing.
Has this been done? Or is it only locally working on your machine?