-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
soc: espressif: Add hardware initialization #80400
Open
LucasTambor
wants to merge
1
commit into
zephyrproject-rtos:main
Choose a base branch
from
LucasTambor:esp/hw_init
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+802
−145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
marekmatej,
raffarost,
sylvioalves,
uLipe and
wmrsouza
October 24, 2024 22:01
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_espressif
DNM
This PR should not be merged (Do Not Merge)
labels
Oct 24, 2024
uLipe
requested changes
Oct 26, 2024
marekmatej
reviewed
Nov 6, 2024
LucasTambor
force-pushed
the
esp/hw_init
branch
from
November 21, 2024 12:46
2a8936d
to
29e4516
Compare
LucasTambor
force-pushed
the
esp/hw_init
branch
2 times, most recently
from
November 22, 2024 13:07
047660b
to
cf75cd3
Compare
LucasTambor
force-pushed
the
esp/hw_init
branch
from
November 22, 2024 19:50
cf75cd3
to
8d4ce68
Compare
wmrsouza
previously approved these changes
Nov 22, 2024
uLipe
previously approved these changes
Nov 24, 2024
marekmatej
previously approved these changes
Nov 25, 2024
sylvioalves
reviewed
Nov 25, 2024
soc/espressif/esp32s3/hw_init.c
Outdated
WSR(MEMCTL, memctl); | ||
#endif /*XCHAL_ERRATUM_572*/ | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you remove this empty line?
Bring hardware initialization to zephyr code base. Signed-off-by: Lucas Tamborrino <[email protected]>
LucasTambor
dismissed stale reviews from marekmatej, uLipe, and wmrsouza
via
November 25, 2024 13:25
bf2f50c
LucasTambor
force-pushed
the
esp/hw_init
branch
from
November 25, 2024 13:25
8d4ce68
to
bf2f50c
Compare
marekmatej
approved these changes
Nov 25, 2024
sylvioalves
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring hardware initialization to zephyr code base.