Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fix PPVCube #187

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[WIP] Fix PPVCube #187

wants to merge 8 commits into from

Commits on Mar 8, 2023

  1. Remove deprecated argument

    @jzuhone
    jzuhone committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    451d490 View commit details
    Browse the repository at this point in the history

  2. use the velocity_los field built into yt. allow for different ftypes … 

    …other than gas. allow for non-cell sampling types.
    @jzuhone
    jzuhone committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    e3bef8c View commit details
    Browse the repository at this point in the history

  3. This is handled internally so don't do it

    @jzuhone
    jzuhone committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    12eeb4a View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary period

    @jzuhone
    jzuhone committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    95ea6ca View commit details
    Browse the repository at this point in the history

  5. Pass additional arguments to create_sky_wcs

    @jzuhone
    jzuhone committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    98bda3b View commit details
    Browse the repository at this point in the history

  6. Catch the case of weight_field not None

    @jzuhone
    jzuhone committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    27a1234 View commit details
    Browse the repository at this point in the history

  7. bugfix

    @jzuhone
    jzuhone committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    a34fd23 View commit details
    Browse the repository at this point in the history

  8. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    2982e96 View commit details
    Browse the repository at this point in the history