-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fix PPVCube #187
base: main
Are you sure you want to change the base?
[WIP] Fix PPVCube #187
Conversation
…other than gas. allow for non-cell sampling types.
for more information, see https://pre-commit.ci
@jzuhone, I've looked this over and it all looks reasonable to me. It sounds like we may try to do a new yt_astro release soon. Should we wait for you to finish the docs so we can include this? |
To be fully transparent there are no real blockers if we want to do a release sooner rather than later. The release process is also smooth enough that we can easily cut one when this goes in, regardless of exactly when it happens :) |
@jzuhone Hi, your ppv branch looks great. I am interested in implementing these changes in my branch as well. I am keen to attempt a rebase. Please let me know if that would be helpful to address the conflicts and close this PR. |
The
PPVCube
class is out of date with both yt and yt_astro_analysis. This PR brings it up to date, in particular:depth_res
, which was originally here for off-axis projections and is now long gone in yt."gas"
.sampling_type="local"
in fields to allow for SPH projections.Still need to fix the docs, hence WIP. This appears to have uncovered a bug in yt which I'll have to resolve separately.