Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#302: 'Listen on' CKEditor template for podcasts #313

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

komejo
Copy link
Contributor

@komejo komejo commented Aug 29, 2024

What issue(s) does this solve?

Adds CKEditor template for the podcast 'Listen On' icons.

What is the new behavior?

Icons! Add links in CKEditor.

Profile requirements:

  • Does deploying this change require a change to config at the site level (choose one)?
    • No config change is required.
    • Yes, and I have written an update hook to apply these config changes.
    • Yes, and I've included updating instructions to be added to the release notes. The next release will need to be a major version increase. (Only do this in special cases.)

Site-level pull requests for testing. Only merge when these PRs are approved:

Create or update any site-level pull requests following the documentation

Checked on develop (TA to do)

  • Brasil
  • China
  • Indonesia

@komejo komejo requested a review from mariacha August 29, 2024 18:48
@komejo komejo mentioned this pull request Aug 29, 2024
4 tasks
Copy link
Collaborator

@mariacha mariacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems good! I'll update the ticket if I find something once I play around with it on the multidev.

@mariacha mariacha merged commit d894898 into main Sep 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants