Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to podcasts #302

Open
2 of 4 tasks
StudioZut opened this issue Aug 9, 2024 · 8 comments
Open
2 of 4 tasks

Add options to podcasts #302

StudioZut opened this issue Aug 9, 2024 · 8 comments
Assignees

Comments

@StudioZut
Copy link
Contributor

StudioZut commented Aug 9, 2024

Add options to podcast pages for "listen on..." like this https://www.wri.org/podcasts/podcast-series-turning-clean-energy-asia

Image

This exampled ^ is simple custom code. Let's add fields in the podcast content type for these different services, and then drop them into the page automatically (if they have a value).

Dev tasks

  • Start on a new branch because the two things below aren't needed after all:
  • Add three new fields to Data content type: Apple Podcasts, Spotify, and Youtube. These should be external link fields, and put them in a "Podcasts" section at the bottom of the page in the same area that contains "Category", "Experts and Staff" etc.
  • Add an update hook that adds these fields to the Data content type, along with the form and view mode updates, to the wri_sites profile. You can throw them into the wri_data module.
  • Instead, create a ckeditor template "Podcast links" that can generate the css to make the three buttons as seen on https://www.wri.org/podcasts/podcast-series-turning-clean-energy-asia
@mariacha mariacha assigned komejo and unassigned komejo Aug 13, 2024
komejo added a commit that referenced this issue Aug 15, 2024
@komejo
Copy link
Contributor

komejo commented Aug 15, 2024

@maria-thinkshout I have some questions about this - I've got the fields / field group added, but I'm stumped about how to add them. We're including the podcast as a media entity in CKEditor, and the current 'listen on' is a markup entity that also gets added in.

Do we currently have a way to add something into CKEditor that pulls info from a node? Also worth noting is that https://www.wri.org/podcasts/podcast-series-turning-clean-energy-asia has not one but two podcasts on the page with 'listen on' groups.

@mariacha
Copy link
Collaborator

Ah, so it is. @monicapatel21 Let's discuss this one in the meeting because we may want to do this as a media element instead of as a content type.

@monicapatel21
Copy link

monicapatel21 commented Aug 27, 2024

Podcasts = embeds right now (not content type)
Media item for podcasts

Add another CK Editor option (in embed) for future content editors

@mariacha
Copy link
Collaborator

Answer - let's make a ckeditor template to quickly add the links in the WYSIWYG.

@mariacha
Copy link
Collaborator

Ok @komejo we're changing approaches here and turning this into a ckeditor template to make the buttons/links, so no new fields needed. This is ready for you when you need your next task

@komejo
Copy link
Contributor

komejo commented Aug 29, 2024

Done - wri_sites: #313
Flagship: https://github.com/wri/wriflagship/pull/1226

Added CKEditor CSS, just update the empty links:

Screenshot 2024-08-29 at 11 50 48 AM


Screenshot 2024-08-29 at 11 42 03 AM

@komejo komejo assigned mariacha and unassigned komejo Aug 29, 2024
mariacha added a commit that referenced this issue Sep 17, 2024
#302: 'Listen on' CKEditor template for podcasts
@mariacha
Copy link
Collaborator

Ok, this is now a template that can be added within the text. See the last comment for how to add/edit:

https://develop-wriflagship.pantheonsite.io/podcasts/promoting-locally-led-adaptation-climate-action

@mariacha mariacha assigned wthomaswri and shannon-paton and unassigned mariacha Sep 19, 2024
@shannon-paton
Copy link

Looks good @mariacha !

@mariacha mariacha self-assigned this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants