fix(EIP712): chainId should support uint256 values
#257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a180279 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
freemanzMrojo
changed the title
chainId should support uint256 valueschainId should support uint256 values
freemanzMrojo
changed the title
chainId should support uint256 valuesEIP712): chainId should support uint256 values
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the largest integer that a
numbercould safely represent in TypeScript is 2^53 - 1, bigger values that are supported byuint256cannot fit into it (some sample values in the issue).Closes #256
PR-Codex overview
This PR introduces a patch to the
abitypepackage, updating thechainIdproperty in theTypedDataDomaintype to acceptuint256values by allowingbigintandstringtypes in addition tonumber.Detailed summary
chainIdtype inTypedDataDomainfromnumbertonumber | bigint | string | undefined.chainIdvalidation inTypedDataDomainfromz.number().optional()toz.union([z.number(), z.string(), z.bigint()]).optional().