Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total removal of Ethers as a dependency #1323

Open
2 of 5 tasks
victhorbi opened this issue Sep 20, 2024 · 2 comments
Open
2 of 5 tasks

Total removal of Ethers as a dependency #1323

victhorbi opened this issue Sep 20, 2024 · 2 comments

Comments

@victhorbi
Copy link
Collaborator

victhorbi commented Sep 20, 2024

*Discussion ongoing here: wevm/viem#2676 (comment)

@victhorbi victhorbi changed the title Total removal of Ethers Total removal of Ethers as a dependency Sep 23, 2024
@victhorbi victhorbi added this to the Audit milestone Sep 30, 2024
@victhorbi
Copy link
Collaborator Author

It's important to note that ethers could have runtime checks in place, and viem doesn't.
For example @freemanzMrojo has confirmed that the checks for eip712 are not available.

Make sure that every time a function gets replaced, the runtime checks are available or we should build them.

@freemanzMrojo
Copy link
Member

I have opened an issue about the topic mentioned above by @victhorbi : wevm/viem#2999

cc: @fabiorigam @lucanicoladebiasi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants