-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use baseText= in TestText or switch to TestValueXX for short cases #5373
base: develop
Are you sure you want to change the base?
Conversation
@visit-dav/visit-developers can I please ask for people to have a look at this and see if it makes sense. For many cases, the The kind of work in this PR means several hundred of our simpler baselined text results can be removed and baseline values can be more conveniently updated directly in the |
Looking for
|
One note for folks to keep in mind - Failure modes for using the new methods might not be exactly the same. Concrete Example:
vs TestValueEQ(GetQueryOutputObject()["min"],0)) GetQueryOutputObject() could return "None" and there is an exception that would stop the rest of the tests from running. Just to be clear: This isn't a bad thing, but might confuse us when changing over. I think we should promote extra checks for bad return values in our CLI. |
FYI...
So, even if
|
Whoops, I should have tested |
Description
This is follow on to #5370 to begin work of replace cases where
TestText()
is used with baseline files that contain a small amount of text which can easily by codified into thebaseText=
option of the call or whereTestValueXX()
methods might work better. So, this will change various.py
test files and remove a slew of baseline.txt
files...I am guessing on the order of 100.But, is that worth it? There are a number of other observations I now have regarding testing and design of our tests that suggest its ripe for an overhaul. Maybe this is less important than that work?
Type of change
Feature...simplify some testing logic
How Has This Been Tested?
Manually on my macOS system.
Checklist: