Bugfix/biagas/fix unstructureddomainboundaries exchange scalars dev #20010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ors (#19991) * Fix avtUnstructuredDomainBoundaries::ExchangeScalars and ExchangeVectors. Ensure all procs are calling the same Exchange function based on dataType that they get from an MPI_Allreduce. This fixes problems in parallel (segv/hang) when avtExtraGhostNodes/Zones are exchanged. Modified avtGenericDatabse to ensure all procs participate in the exchange of avtExtraGhostNodes/Zones. * Don't attempt to exchange extraGhost info is no process posesses the info. * Add consistency checks of datatypes for ExchangeScalar and ExchangeVector. * Update consistency test so that the Exception isn't thrown in a case where one proc doesn't have data (dataType == -1). * Tweaks to data-type consistency check to preven hang.
Mili plugin sets it to true when it will generate extraGhostInfo. Update avtGenericDatabase to test this flag before calling code that utilizes extra ghost information.
markcmiller86
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Its a shame one has to update all those dogon baseline files in situations like this. I have a long overdue PR (#5373) that would improve this situation somewhat but I've let in languish.
JustinPrivitera
approved these changes
Nov 4, 2024
biagas
deleted the
bugfix/biagas/fix_unstructureddomainboundaries_exchange_scalars_dev
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #19988.
This is a merge from 3.4RC (#19991) with the addition of:
A new avtMeshMetaData field: hasExtraGhostInfo. This flag is false by default, and Mili plugin sets it to true when it will create ExtraGhost information.
Modified avtGenericDatabase to use this new flag to test whether or not to call code that utilizes avtExtraGhost information, rather than the convoluted logic needed on 3.4RC since we couldn't change the MetaData.
Updated all baseline text files that print MeshMetaData due to the new field.
Type of change
[ ] New feature[ ] Documentation update[ ] OtherHow Has This Been Tested?
I ran the full regression suite in parallel on poodle with success.
Checklist:
[ ] I have updated the release notes.[ ] I have made corresponding changes to the documentation.[ ] I have added debugging support to my changes.[ ] I have added tests that prove my fix is effective or that my feature works.[ ] I have added new baselines for any new tests to the repo.[ ] I have NOT made any changes to protocol or public interfaces in an RC branch.