RSDK-9290 - Bump go to 1.23 #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
safe to test
viambot
added
safe to test
cheukt
commented
Nov 18, 2024
| - gen$ | ||
| - vendor$ | ||
| - test$ | ||
| skip-dirs-use-default: false | ||
| tests: true | ||
| linters: | ||
| enable-all: true | ||
| disable: | ||
| - asasalint |
There was a problem hiding this comment.
all the changes to disabled linters are mirrored from rdk
| @@ -57,7 +57,7 @@ func NewCloudExporter(opts CloudOptions) (Exporter, error) { | |||
| zone := os.Getenv("GCP_COMPUTE_ZONE") | |||
| if zone == "" { | |||
| // Get from GCP Metadata | |||
| if zone, err = metadata.Zone(); err != nil { | |||
| if zone, err = metadata.ZoneWithContext(sdOpts.Context); err != nil { | |||
There was a problem hiding this comment.
could see just using a background context as well, not clear if the context used here is the right one
abe-winter
approved these changes
Nov 18, 2024
dgottlieb
approved these changes
Nov 19, 2024
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it was more work to get the linter to work properly without bumping the go version
mostly took inspiration from the equivalent bump in rdk
most of the changes came from just running lint