Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submission for challenge #4

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Submission for challenge #4

wants to merge 19 commits into from

Commits on Dec 13, 2015

  1. Untrack workspace.xml

    @JavierGelatti
    JavierGelatti committed Dec 13, 2015
    Configuration menu
    Copy the full SHA
    f967ca0 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2015

  1. Untrack .zip files (fitnesse)

    @JavierGelatti
    JavierGelatti committed Dec 14, 2015
    Configuration menu
    Copy the full SHA
    e2919b5 View commit details
    Browse the repository at this point in the history

  2. Test ArrowKillWumpus in all directions

    @JavierGelatti
    JavierGelatti committed Dec 14, 2015
    Configuration menu
    Copy the full SHA
    16078ba View commit details
    Browse the repository at this point in the history

  3. Extract scenario to test that the arrow stops when hitting the Wumpus

    @JavierGelatti
    JavierGelatti committed Dec 14, 2015
    Configuration menu
    Copy the full SHA
    1089163 View commit details
    Browse the repository at this point in the history

  4. Promote test arrow stops when hitting Wumpus to test page

    @JavierGelatti
    JavierGelatti committed Dec 14, 2015
    Configuration menu
    Copy the full SHA
    5ccef9d View commit details
    Browse the repository at this point in the history

  5. Clear the map when given a new map

    @JavierGelatti
    JavierGelatti committed Dec 14, 2015
    Configuration menu
    Copy the full SHA
    2a36ff8 View commit details
    Browse the repository at this point in the history

  6. Extract scenario for ArrowsAccumulateInFarthestCavern test

    @JavierGelatti
    JavierGelatti committed Dec 14, 2015
    Configuration menu
    Copy the full SHA
    86f2239 View commit details
    Browse the repository at this point in the history

  7. Test ArrowsAccumulateInFarthestCavern in all directions

    @JavierGelatti
    JavierGelatti committed Dec 14, 2015
    Configuration menu
    Copy the full SHA
    934a34b View commit details
    Browse the repository at this point in the history

  8. Rename finalCavern argument to farthestCavern

    @JavierGelatti
    JavierGelatti committed Dec 14, 2015
    Configuration menu
    Copy the full SHA
    c55e90c View commit details
    Browse the repository at this point in the history

  9. Test that if the Wumpus stops the arrow, the player is not killed by … 

    …shooting in circle
    @JavierGelatti
    JavierGelatti committed Dec 14, 2015
    Configuration menu
    Copy the full SHA
    673c829 View commit details
    Browse the repository at this point in the history

  10. Extract scenario in PlayerCanNotShootWithoutArrows test

    @JavierGelatti
    JavierGelatti committed Dec 14, 2015
    Configuration menu
    Copy the full SHA
    33863c4 View commit details
    Browse the repository at this point in the history

  11. Test PlayerCanNotShootWithoutArrows in all directions

    @JavierGelatti
    JavierGelatti committed Dec 14, 2015
    Configuration menu
    Copy the full SHA
    6d4d87d View commit details
    Browse the repository at this point in the history

  12. Extract scenario in PlayerKilledByShootingWall test

    @JavierGelatti
    JavierGelatti committed Dec 14, 2015
    Configuration menu
    Copy the full SHA
    43757c2 View commit details
    Browse the repository at this point in the history

  13. Add more cases in PlayerKilledByShootingWall test

    @JavierGelatti
    JavierGelatti committed Dec 14, 2015
    Configuration menu
    Copy the full SHA
    0cf178e View commit details
    Browse the repository at this point in the history

  14. Generalize scenario in ArrowsAccumulateInFarthestCavern test

    @JavierGelatti
    JavierGelatti committed Dec 14, 2015
    Configuration menu
    Copy the full SHA
    87a624e View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2015

  1. Extract method connectionsOf(...)

    @JavierGelatti
    JavierGelatti committed Dec 19, 2015
    Configuration menu
    Copy the full SHA
    e3a7205 View commit details
    Browse the repository at this point in the history

  2. Replace imperative style for traversing collections with functional s… 

    …tyle
    @JavierGelatti
    JavierGelatti committed Dec 19, 2015
    Configuration menu
    Copy the full SHA
    00a67b8 View commit details
    Browse the repository at this point in the history

  3. Implement missing test 

    I discovered an implemented feature that was not tested.
Then, I had to choose between two paths:
    1. Deleting the feature (if it's not in the requirements, then it
       should not be in the code), or
    2. Adding a test, to justify the existence of the feature.

I chose to add a new test (2), because I wanted to practice with FitNesse,
but in a real project I would consider the other option a little more (an
arrow can travel at most 103 caverns? and it isn't in the requirements?
sounds suspicious...)
    @JavierGelatti
    JavierGelatti committed Dec 19, 2015
    Configuration menu
    Copy the full SHA
    9678d82 View commit details
    Browse the repository at this point in the history

  4. Extract randomChoice method

    @JavierGelatti
    JavierGelatti committed Dec 19, 2015
    Configuration menu
    Copy the full SHA
    5448b4b View commit details
    Browse the repository at this point in the history