Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submission for challenge #4

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Submission for challenge #4

wants to merge 19 commits into from

Conversation

JavierGelatti
Copy link

This is my submission for the challenge. It was my first time using FitNesse, but I enjoyed using it and learned a lot while doing it.
This month I started reading the Refactoring book, so I did the changes in little steps (and always running the tests in between).

A summary of the changes:

  • Implemented a missing test (see commit 9678d82)
  • Introduced functional style for traversing collections
  • Tested that if the Wumpus stops the arrow, the player is not killed by shooting in circle
  • Added all direction cases to some tests
  • Extracted some methods
  • Untracked some FitNesse files

@JavierGelatti
Untrack workspace.xml
f967ca0
@JavierGelatti
Untrack .zip files (fitnesse)
e2919b5
@JavierGelatti
Test ArrowKillWumpus in all directions
16078ba
@JavierGelatti
Extract scenario to test that the arrow stops when hitting the Wumpus
1089163
@JavierGelatti
Promote test arrow stops when hitting Wumpus to test page
5ccef9d
@JavierGelatti
Clear the map when given a new map
2a36ff8
@JavierGelatti
Extract scenario for ArrowsAccumulateInFarthestCavern test
86f2239
@JavierGelatti
Test ArrowsAccumulateInFarthestCavern in all directions
934a34b
@JavierGelatti
Rename finalCavern argument to farthestCavern
c55e90c
@JavierGelatti
Test that if the Wumpus stops the arrow, the player is not killed by …
673c829 
…shooting in circle
@JavierGelatti
Extract scenario in PlayerCanNotShootWithoutArrows test
33863c4
@JavierGelatti
Test PlayerCanNotShootWithoutArrows in all directions
6d4d87d
@JavierGelatti
Extract scenario in PlayerKilledByShootingWall test
43757c2
@JavierGelatti
Add more cases in PlayerKilledByShootingWall test
0cf178e
@JavierGelatti
Generalize scenario in ArrowsAccumulateInFarthestCavern test
87a624e
@JavierGelatti
Extract method connectionsOf(...)
e3a7205
@JavierGelatti
Replace imperative style for traversing collections with functional s…
00a67b8 
…tyle
@JavierGelatti
Implement missing test
9678d82 
I discovered an implemented feature that was not tested.
Then, I had to choose between two paths:
    1. Deleting the feature (if it's not in the requirements, then it
       should not be in the code), or
    2. Adding a test, to justify the existence of the feature.

I chose to add a new test (2), because I wanted to practice with FitNesse,
but in a real project I would consider the other option a little more (an
arrow can travel at most 103 caverns? and it isn't in the requirements?
sounds suspicious...)
@JavierGelatti
Extract randomChoice method
5448b4b
@JavierGelatti JavierGelatti mentioned this pull request Dec 25, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JavierGelatti