security: Only show prompt when unlocking #45
Conversation
Do not show the unlock prompt when the system is already unlocked or preparing to lock. Signed-off-by: Tim Crawford <[email protected]>
There was a problem hiding this comment.
I now only see the prompt when the state is PrepareUnlock.
If the state is PrepareUnlock but I've only rebooted the machine, I still get a pointless prompt, since completing this prompt does not change the state from PrepareUnlock. This makes the ectool script seem broken. However, if I shut down like the prompt tells me to, the state does change like it should after I complete the prompt.
Another observation: after locking or unlocking with the ectool script and shutting down, the machine reboots itself automatically without having to press the power button. This doesn't really have anything to do with this PR, but I found it interesting enough to mention.
|
Machine must be shutdown after unlocking to go from |
Do not show the unlock prompt when the system is already unlocked or preparing to lock.