-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tool: Add error for write locked #450
Conversation
44792a4
to
acc5b08
Compare
After running That doesn't feel correct? I would expect it to prompt for a single boot, and then the standard locked behaviour to reassert on subsequent boots. |
Also, should the post Currently |
Add a new error for the case of trying to flash when security is enabled and it is still locked and update the related docs. Signed-off-by: Tim Crawford <[email protected]>
This change was reverted; it's intended behavior for it to show up even when unlocked.
Per UEFI wording for ResetType, "Shutdown" is the correct type of event. "Cold" and "Warm" are reset events that will not trigger the EC logic to reboot unlocked. |
acc5b08
to
2a2e4b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks to be working as desired still, and all my concerns/thoughts have been addressed and reviewed.
Add a new error for the case of trying to flash when security is enabled and it is still locked and update the related docs.