Mavenize the project #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
paulvi
reviewed
Nov 27, 2018
| <url>https://github.com/dakusui/ditaa</url> | ||
| <connection>scm:git:git://github.com/dakusui/ditaa.git</connection> | ||
| <developerConnection>scm:git:ssh://[email protected]/dakusui/ditaa.git</developerConnection> | ||
| <tag>95a481e5a01d07317edc4af4cbdfb4c821090437</tag> |
There was a problem hiding this comment.
this tag value came from some example where maven project was release.
Should not be here, as fare as I know
There was a problem hiding this comment.
Thank you for pointing out.
I'm closing this pull request since this is not necessary anymore.
|
Since the pull request that depends on this was reworked in #54 and this became unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request offers a fix for Issue #40 , "Mavenization".
Actually, I'm not sure if this is a branch for pull requesting.
Please let me know the way you prefer to be pull requested.