Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mavenization #40

Closed
dakusui opened this issue Oct 27, 2018 · 2 comments
Closed

Mavenization #40

dakusui opened this issue Oct 27, 2018 · 2 comments

Comments

@dakusui
Copy link

dakusui commented Oct 27, 2018

The current version of ditaa relies on 'leiningen' for its build. However it is less popular and has less supports from major IDE's.
To be honest, I could not figure out how to import ditaa's project directly into my IntelliJ and I had to resort to lein pom to convert project.clj.

I think it would be very helpful if we have pom.xml , which is a project descriptor in maven's ecosystem out of the box since it was not straightforward to make it work.

Actually, I have already created pom.xml in my forked repository and would open a pull request for it. Please have a look at it and consider merging it when it becomes ready.

@dakusui
Copy link
Author

dakusui commented Oct 27, 2018

Sorry, I found this remark in the README now.

Ditaa is going to be gradually rewritten in Clojure (starting with the tests), so it now uses Leiningen for building. In order to get a new stand-alone jar file, just switch into ditaa's top-level dir and type:

But still this fix (the pull request #41) is a basis of my enhancement for #39 (LaTeX math support). If it interests you, please consider integrating the included pom.xml temporarily.

@dakusui
Copy link
Author

dakusui commented Aug 24, 2019

Since I have succeeded in implementing #39 without relying on maven (directly), so this is not a blocker for the feature anymore.
So I am closing this ticket.
In case mavenization becomes necessary again, let's file another ticket.

@dakusui dakusui closed this as completed Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant