Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][Python] link name's default value for get* methods. #487

Merged
merged 2 commits into from
Mar 16, 2017

Conversation

130s
Copy link
Contributor

@130s 130s commented Mar 16, 2017

Same as fkanehiro/hrpsys-base#1118.

Once fkanehiro/hrpsys-base#1118 gets merged, we can revert the 1st commit of this PR.

And not to mention that once #470 gets merged, we need to revert HrpsysConfigurator2.

@130s 130s merged commit 9f00b63 into start-jsk:indigo-devel Mar 16, 2017
@130s 130s deleted the fix/getRefPose_arg branch March 16, 2017 21:17
@130s
Copy link
Contributor Author

130s commented Mar 17, 2017

For the concern raised in fkanehiro/hrpsys-base#1118 (comment) for the older versions of hrpsys (< 315.3.x), a couple of the particular tests for 315_1_10 passed as following, so my decision at least for Hironx was ok to merge

[hironx_ros_bridge.rosunit-test_hironx_target/testGetCurrentPose][passed]
[hironx_ros_bridge.rosunit-test_hironx_target/testGetReferencePose][passed]

130s added a commit to 130s/rtmros_hironx that referenced this pull request Mar 17, 2017
Function object cannot be compared with a string.
130s added a commit that referenced this pull request Mar 18, 2017
[hironx py] Fix a new bug added in #487.
130s added a commit to 130s/rtmros_hironx that referenced this pull request Mar 23, 2017
Function object cannot be compared with a string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant