Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement collision checker node #301

Open
wants to merge 9 commits into
base: hydro-devel
Choose a base branch
from

Conversation

DaikiMaekawa
Copy link
Member

#36 Implement new node for stop motion when collisions are detected.

Do not merge yet !!

Review on Reviewable

@DaikiMaekawa
Copy link
Member Author

We need to add the code for stopping the arms.

* copyright notice, this list of conditions and the following
* disclaimer in the documentation and/or other materials provided
* with the distribution.
* * Neither the name of JSK Lab, University of Tokyo. nor the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyrights mismatch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, It's copy/pasted from the other program. That is set right here.

@130s
Copy link
Contributor

130s commented Dec 24, 2014

We need to add the code for stopping the arms.

Adding some background to this;

@DaikiMaekawa and I discussed about what and how we want to address #36, and took this approach: let MoveIt! detect self-collision. When a collision is found then give the "stop" signal by overwriting the command with the current pose of very instantaneous moment.

Testing on the real robot, however, we found that the "stop" signal didn't interrupt the previous command (I think that's why the lines around here are commented out in this PReq).

Another concern in this approach is that there's no effect to the lower level hrpsys commands.

Our conclusion with this PReq is that:

@DaikiMaekawa
Copy link
Member Author

Our checked this node behavior in simulation.

screenshot_from_2014-12-22 13 29 15

screenshot_from_2014-12-22 13 28 08

It was completed to detecting collisions, but the stop motion is not implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants