Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3739: Update NRM geometry, affine distortion use #8974

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from

stdatamodels requirement back to main branch

8f38d3f
Select commit
Loading
Failed to load commit list.
Draft

JP-3739: Update NRM geometry, affine distortion use #8974

stdatamodels requirement back to main branch
8f38d3f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 20, 2024 in 1s

62.52% (-2.01%) compared to 5a2d0cd

View this Pull Request on Codecov

62.52% (-2.01%) compared to 5a2d0cd

Details

Codecov Report

Attention: Patch coverage is 24.56140% with 172 lines in your changes missing coverage. Please review.

Project coverage is 62.52%. Comparing base (5a2d0cd) to head (8f38d3f).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
jwst/ami/oifits.py 7.54% 98 Missing ⚠️
jwst/ami/ami_analyze_step.py 28.20% 28 Missing ⚠️
jwst/ami/leastsqnrm.py 9.52% 19 Missing ⚠️
jwst/ami/mask_definition_ami.py 63.15% 14 Missing ⚠️
jwst/ami/lg_model.py 28.57% 5 Missing ⚠️
jwst/ami/ami_analyze.py 62.50% 3 Missing ⚠️
jwst/ami/instrument_data.py 66.66% 2 Missing ⚠️
jwst/ami/find_affine2d_parameters.py 0.00% 1 Missing ⚠️
jwst/ami/mask_definitions.py 0.00% 1 Missing ⚠️
jwst/ami/nrm_core.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8974      +/-   ##
==========================================
- Coverage   64.52%   62.52%   -2.01%     
==========================================
  Files         375      376       +1     
  Lines       38739    38921     +182     
==========================================
- Hits        24997    24335     -662     
- Misses      13742    14586     +844     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features: