-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing ignore script - RSC-980 #704
base: main
Are you sure you want to change the base?
Changes from all commits
c741a31
d82ae80
672d48a
91ae2d0
35c5ea0
3d0d3ea
6f5fd2d
ead0d2f
23e7e98
48dd3a9
7e65adc
1eaecd2
1435959
f59e5ea
b34cd50
dcfb502
abe6243
a495a26
aa97e56
bfecf8a
e5e3975
d4d5181
1c40015
bfe7314
b35b3e0
71b7522
190825b
eef981b
bbf7055
d93c19d
dfa98cb
601b671
0e55590
9d85493
2b1c31b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
enableScripts: false | ||
|
||
nodeLinker: "node-modules" | ||
|
||
npmRegistryServer: "https://registry.npmjs.org" |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,3 +15,5 @@ RUN apt-get update && \ | |
RUN useradd -u 1002 -g 100 jenkins | ||
RUN mkdir -p /home/jenkins/.npm | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. DL3059: Multiple consecutive (at-me in a reply with Was this a good recommendation? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. DL3059: Multiple consecutive (at-me in a reply with Was this a good recommendation? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. DL3059: Multiple consecutive (at-me in a reply with Was this a good recommendation? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. DL3059: Multiple consecutive (at-me in a reply with Was this a good recommendation? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. DL3059: Multiple consecutive (at-me in a reply with Was this a good recommendation? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. DL3059: Multiple consecutive (at-me in a reply with Was this a good recommendation? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. DL3059: Multiple consecutive (at-me in a reply with Was this a good recommendation? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. DL3059: Multiple consecutive (at-me in a reply with Was this a good recommendation? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. DL3059: Multiple consecutive (at-me in a reply with Was this a good recommendation? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. DL3059: Multiple consecutive (at-me in a reply with Was this a good recommendation? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. DL3059: Multiple consecutive (at-me in a reply with Was this a good recommendation? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. DL3059: Multiple consecutive (at-me in a reply with Was this a good recommendation? |
||
RUN chown -R jenkins /home/jenkins/ | ||
|
||
RUN yarn set version berry |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -150,8 +150,14 @@ The RSC code is split into two separate codebases: the library itself which live | |
## Building | ||
|
||
### Required Software | ||
Node 10.x or 12.x. Node 14.x is known not to work currently. | ||
yarn 1.21.1 | ||
<!-- Node 10.x or 12.x. Node 14.x is known not to work currently. --> | ||
Node 12.x | ||
Comment on lines
+153
to
+154
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is out of date even before this PR. We're on Node 16 now and also support 14 |
||
yarn 3.2 | ||
|
||
Go to lib/ or/and gallery/ directory and run: | ||
`yarn set version berry` | ||
|
||
You must run `yarn install` each time you switch between branches. | ||
|
||
### Installation of Dependencies | ||
In the lib/ directory, run `yarn install` | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
/.yarn/releases/** binary | ||
/.yarn/plugins/** binary |
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
enableScripts: false | ||
|
||
nodeLinker: node-modules | ||
|
||
npmRegistryServer: "https://registry.npmjs.org" | ||
|
||
yarnPath: .yarn/releases/yarn-3.2.0.cjs |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"name": "@sonatype/react-shared-components-gallery", | ||
"version": "10.0.5", | ||
"version": "10.0.6", | ||
"description": "Gallery application to demonstrate usage and look of Sonatype shared UI components", | ||
"main": "src/main.ts", | ||
"scripts": { | ||
|
@@ -12,7 +12,7 @@ | |
"webpack": "webpack --env production --mode=production", | ||
"webpack-dev-server": "webpack serve", | ||
"test": "npm-run-all check-install lint-tests build jest", | ||
"check-install": "yarn install --check-files --frozen-lockfile", | ||
"check-install": "yarn install --check-cache --immutable", | ||
"jest": "jest --testTimeout=120000", | ||
"clean": "rimraf dist webpack-modules test-results" | ||
}, | ||
|
@@ -68,19 +68,26 @@ | |
"@fortawesome/free-solid-svg-icons": "^5.15.4", | ||
"@fortawesome/react-fontawesome": "^0.1.14", | ||
"@react-hook/debounce": "^4.0.0", | ||
"@sonatype/react-shared-components": "link:../lib/dist", | ||
"@sonatype/react-shared-components": "../lib/dist", | ||
"axios": "^0.21.1", | ||
"classnames": "^2.2.6", | ||
"compare-versions": "^4.1.3", | ||
"core-js": "^3.8.3", | ||
"es6-object-assign": "^1.1.0", | ||
"es6-set": "^0.1.5", | ||
"link": "^1.4.0", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Oh I meant to remove that! |
||
"query-string": "^6.13.8", | ||
"ramda": "^0.28.0", | ||
"react": "^16.14.0", | ||
"react-dom": "^16.14.0", | ||
"react-router": "^5.2.0", | ||
"react-router-dom": "^5.2.0", | ||
"react-syntax-highlighter": "^15.4.3" | ||
} | ||
}, | ||
"dependenciesMeta": { | ||
"puppeteer": { | ||
"built": true | ||
} | ||
}, | ||
"packageManager": "[email protected]" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DL3059: Multiple consecutive
RUN
instructions. Consider consolidation.(at-me in a reply with
help
orignore
)Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]