Testing ignore script - RSC-980 #704

entroform · 2022-04-19T20:38:43Z

puppeteer/puppeteer#5239
https://yarnpkg.com/getting-started/qa/#which-files-should-be-gitignored

sonatype-lift · 2022-04-26T14:53:12Z

Dockerfile

@@ -15,3 +15,5 @@ RUN apt-get update && \
 RUN useradd -u 1002 -g 100 jenkins
 RUN mkdir -p /home/jenkins/.npm


DL3059: Multiple consecutive RUN instructions. Consider consolidation.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-04-26T14:59:53Z

Dockerfile

@@ -15,3 +15,5 @@ RUN apt-get update && \
 RUN useradd -u 1002 -g 100 jenkins
 RUN mkdir -p /home/jenkins/.npm


DL3059: Multiple consecutive RUN instructions. Consider consolidation.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-04-26T15:28:13Z

Dockerfile

@@ -15,3 +15,5 @@ RUN apt-get update && \
 RUN useradd -u 1002 -g 100 jenkins
 RUN mkdir -p /home/jenkins/.npm


DL3059: Multiple consecutive RUN instructions. Consider consolidation.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-04-26T16:49:08Z

Dockerfile

@@ -15,3 +15,5 @@ RUN apt-get update && \
 RUN useradd -u 1002 -g 100 jenkins
 RUN mkdir -p /home/jenkins/.npm


DL3059: Multiple consecutive RUN instructions. Consider consolidation.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-04-26T17:34:23Z

Dockerfile

@@ -15,3 +15,5 @@ RUN apt-get update && \
 RUN useradd -u 1002 -g 100 jenkins
 RUN mkdir -p /home/jenkins/.npm


DL3059: Multiple consecutive RUN instructions. Consider consolidation.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-04-26T18:00:39Z

Dockerfile

@@ -15,3 +15,5 @@ RUN apt-get update && \
 RUN useradd -u 1002 -g 100 jenkins
 RUN mkdir -p /home/jenkins/.npm


DL3059: Multiple consecutive RUN instructions. Consider consolidation.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-04-26T18:12:27Z

Dockerfile

@@ -15,3 +15,5 @@ RUN apt-get update && \
 RUN useradd -u 1002 -g 100 jenkins
 RUN mkdir -p /home/jenkins/.npm


DL3059: Multiple consecutive RUN instructions. Consider consolidation.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-04-26T18:16:29Z

Dockerfile

@@ -15,3 +15,5 @@ RUN apt-get update && \
 RUN useradd -u 1002 -g 100 jenkins
 RUN mkdir -p /home/jenkins/.npm


DL3059: Multiple consecutive RUN instructions. Consider consolidation.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-04-26T18:24:45Z

Dockerfile

@@ -15,3 +15,5 @@ RUN apt-get update && \
 RUN useradd -u 1002 -g 100 jenkins
 RUN mkdir -p /home/jenkins/.npm


DL3059: Multiple consecutive RUN instructions. Consider consolidation.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-04-26T18:44:59Z

Dockerfile

@@ -15,3 +15,5 @@ RUN apt-get update && \
 RUN useradd -u 1002 -g 100 jenkins
 RUN mkdir -p /home/jenkins/.npm


DL3059: Multiple consecutive RUN instructions. Consider consolidation.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-04-26T18:45:28Z

Dockerfile

@@ -15,3 +15,5 @@ RUN apt-get update && \
 RUN useradd -u 1002 -g 100 jenkins
 RUN mkdir -p /home/jenkins/.npm


DL3059: Multiple consecutive RUN instructions. Consider consolidation.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-04-26T18:52:58Z

Dockerfile

@@ -15,3 +15,5 @@ RUN apt-get update && \
 RUN useradd -u 1002 -g 100 jenkins
 RUN mkdir -p /home/jenkins/.npm


DL3059: Multiple consecutive RUN instructions. Consider consolidation.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-04-26T19:30:55Z

Dockerfile

@@ -15,3 +15,5 @@ RUN apt-get update && \
 RUN useradd -u 1002 -g 100 jenkins
 RUN mkdir -p /home/jenkins/.npm


DL3059: Multiple consecutive RUN instructions. Consider consolidation.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

rpokorny · 2022-04-27T21:18:57Z

README.md

+<!-- Node 10.x or 12.x. Node 14.x is known not to work currently. -->
+Node 12.x


This is out of date even before this PR. We're on Node 16 now and also support 14

rpokorny · 2022-04-27T21:21:25Z

lib/.gitignore

+!.yarn/plugins
+!.yarn/releases
+!.yarn/sdks
+!.yarn/versions


We have a top-level .gitignore which woul be the right place for these entries that are in both lib and gallery

rpokorny · 2022-04-27T21:22:04Z

gallery/package.json

    "axios": "^0.21.1",
    "classnames": "^2.2.6",
    "compare-versions": "^4.1.3",
    "core-js": "^3.8.3",
    "es6-object-assign": "^1.1.0",
    "es6-set": "^0.1.5",
+    "link": "^1.4.0",


What's this?

What's this?

Oh I meant to remove that!

rpokorny · 2022-04-27T21:23:55Z

Could you explain what it is about yarn 2+ that enables the installation of puppeteer without running its install scripts?

rpokorny · 2022-04-27T21:37:23Z

I suspect an alternative to switching our yarn version would be to use puppeteer's environment variables to disable the download and provide it the path to the chromium executable already present on the system. See https://dev.to/maxprogramming/how-to-skip-chromium-download-in-puppeteer-2c24

entroform · 2022-05-02T15:16:52Z

Could you explain what it is about yarn 2+ that enables the installation of puppeteer without running its install scripts?

So in yarnrc.yml
I set it so it disables script by default:

enableScripts: false

Then in package.json, I added this configuration to allow scripts on a specific module:

 "dependenciesMeta": {
    "puppeteer": {
      "built": true
    }
  },

https://yarnpkg.com/configuration/manifest#dependenciesMeta.built

entroform · 2022-05-02T15:18:44Z

I suspect an alternative to switching our yarn version would be to use puppeteer's environment variables to disable the download and provide it the path to the chromium executable already present on the system. See https://dev.to/maxprogramming/how-to-skip-chromium-download-in-puppeteer-2c24

Thanks! I'll see if I can get this to work on another branch!

Andrew Prasetya added 22 commits April 19, 2022 16:37

Testing ignore-script. - RSC-980

c741a31

Bumped versions. - RSC-980

d82ae80

Added yarn rebuild. - RSC-980

672d48a

Merge branch 'main' into RSC-980_ignore-script

91ae2d0

Updated versions. - RSC-980

35c5ea0

Added update yarn. - RSC-980

3d0d3ea

Updated Dockerfile to update yarn - RSC-980

6f5fd2d

Updated to yarn 2 configs. - RSC-980

ead0d2f

Fixed yaml. - RSC-980

23e7e98

Updated yarnrc. - RSC-980

48dd3a9

Removed ignore-scripts. - rSC-980

7e65adc

Used CI=true. - RSC-980

1eaecd2

Updated lock. - RSC-980

1435959

Disabled IMMUTABLE installs. - RSC-980

f59e5ea

Enable build for rsc. - RSC-980

b34cd50

Reverted yarn.lock. - RSC-980

dcfb502

Updated package and lock to newer version. - RSC-980

abe6243

Fixed conflicts. - RSC-980

a495a26

Progress. - RSC-980

aa97e56

Removed .yarn from git. - RSC-980

bfecf8a

Fixed yarn 2 issues. - RSC-980

e5e3975

Removed yarn cache. - RSC-980

d4d5181

sonatype-lift bot reviewed Apr 26, 2022

View reviewed changes

Added releases back into .yarn. - RSC-980

1c40015

sonatype-lift bot reviewed Apr 26, 2022

View reviewed changes

Andrew Prasetya added 2 commits April 26, 2022 11:08

Added README.md and git attributes. - RSC-980

bfe7314

Added README.md and git attributes. - RSC-980

b35b3e0

sonatype-lift bot reviewed Apr 26, 2022

View reviewed changes

Disabled IMMUTABLE installs. - RSC-980

71b7522

sonatype-lift bot reviewed Apr 26, 2022

View reviewed changes

Updated yarn.lock and added --immutable. - RSC-980

190825b

sonatype-lift bot reviewed Apr 26, 2022

View reviewed changes

Used yarn config to set registry. Disable immutable installs. - RSC-980

eef981b

sonatype-lift bot reviewed Apr 26, 2022

View reviewed changes

Andrew Prasetya added 2 commits April 26, 2022 14:06

Updated ssr lock. - RSC-980

bbf7055

Fixed Jenkinsfile. - RSC-980

d93c19d

sonatype-lift bot reviewed Apr 26, 2022

View reviewed changes

Disable immutable installs again. - RSC-980

dfa98cb

sonatype-lift bot reviewed Apr 26, 2022

View reviewed changes

Andrew Prasetya added 2 commits April 26, 2022 14:35

Updated gallery lock. - RSC-980

601b671

Added immutable to ssr ops. - RSC-980

0e55590

sonatype-lift bot reviewed Apr 26, 2022

View reviewed changes

Allow mutate lock for gallery. - RSC-980

9d85493

sonatype-lift bot reviewed Apr 26, 2022

View reviewed changes

Updated SSR install. - RSC-980

2b1c31b

sonatype-lift bot reviewed Apr 26, 2022

View reviewed changes

rpokorny reviewed Apr 27, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Testing ignore script - RSC-980 #704

Testing ignore script - RSC-980 #704

entroform commented Apr 19, 2022 •

edited

Loading

sonatype-lift bot Apr 26, 2022

sonatype-lift bot Apr 26, 2022

sonatype-lift bot Apr 26, 2022

sonatype-lift bot Apr 26, 2022

sonatype-lift bot Apr 26, 2022

sonatype-lift bot Apr 26, 2022

sonatype-lift bot Apr 26, 2022

sonatype-lift bot Apr 26, 2022

sonatype-lift bot Apr 26, 2022

sonatype-lift bot Apr 26, 2022

sonatype-lift bot Apr 26, 2022

sonatype-lift bot Apr 26, 2022

sonatype-lift bot Apr 26, 2022

rpokorny Apr 27, 2022

rpokorny Apr 27, 2022

rpokorny Apr 27, 2022

entroform May 2, 2022

rpokorny commented Apr 27, 2022

rpokorny commented Apr 27, 2022

entroform commented May 2, 2022

entroform commented May 2, 2022 •

edited

Loading

		@@ -15,3 +15,5 @@ RUN apt-get update && \
		RUN useradd -u 1002 -g 100 jenkins
		RUN mkdir -p /home/jenkins/.npm

		<!-- Node 10.x or 12.x. Node 14.x is known not to work currently. -->
		Node 12.x

Testing ignore script - RSC-980 #704

Are you sure you want to change the base?

Testing ignore script - RSC-980 #704

Conversation

entroform commented Apr 19, 2022 • edited Loading

sonatype-lift bot Apr 26, 2022

Choose a reason for hiding this comment

sonatype-lift bot Apr 26, 2022

Choose a reason for hiding this comment

sonatype-lift bot Apr 26, 2022

Choose a reason for hiding this comment

sonatype-lift bot Apr 26, 2022

Choose a reason for hiding this comment

sonatype-lift bot Apr 26, 2022

Choose a reason for hiding this comment

sonatype-lift bot Apr 26, 2022

Choose a reason for hiding this comment

sonatype-lift bot Apr 26, 2022

Choose a reason for hiding this comment

sonatype-lift bot Apr 26, 2022

Choose a reason for hiding this comment

sonatype-lift bot Apr 26, 2022

Choose a reason for hiding this comment

sonatype-lift bot Apr 26, 2022

Choose a reason for hiding this comment

sonatype-lift bot Apr 26, 2022

Choose a reason for hiding this comment

sonatype-lift bot Apr 26, 2022

Choose a reason for hiding this comment

sonatype-lift bot Apr 26, 2022

Choose a reason for hiding this comment

rpokorny Apr 27, 2022

Choose a reason for hiding this comment

rpokorny Apr 27, 2022

Choose a reason for hiding this comment

rpokorny Apr 27, 2022

Choose a reason for hiding this comment

entroform May 2, 2022

Choose a reason for hiding this comment

rpokorny commented Apr 27, 2022

rpokorny commented Apr 27, 2022

entroform commented May 2, 2022

entroform commented May 2, 2022 • edited Loading

entroform commented Apr 19, 2022 •

edited

Loading

entroform commented May 2, 2022 •

edited

Loading